11 Commits

Author	SHA1	Message	Date
WGH	47be22e62a	Use std::shared_ptr for variable resolution ... AnchoredSetVariable::resolve is called for every rule (see RuleWithOperator::evaluate). The previous implementation allocated a new copy of every variable, which quickly added up. In my tests, AnchoredSetVariable::resolve function consumed 7.8% of run time. AnchoredSetVariable (which is a multimap) values are never changed, only added. This means it's safe to store them in std::shared_ptr, and make resolve return shared_ptr pointing to the same object. Other resolve implementation could also use this optimization by not allocating new objects, however, they are not hot spots, so this optimization was not implemented there. In my benchmark, this raises performance from 117 requests per second to 131 RPS, and overhead is lowered from 7.8% to 2.4%. As a bonus, replacing plain pointer with smart pointers make code cleaner, since using smart pointers makes manual deletes no longer necessary. Additionally, VariableOrigin is now stored in plain std::vector, since it's wasteful to store structure containing just two integer values using std::list<std::unique_ptr<T>>.	2020-08-10 10:35:07 -03:00
Felipe Zimmerle	32e776daa9	Makes operator to use string_view	2020-08-06 21:36:11 -03:00
Felipe Zimmerle	357c140003	Changens copyright year	2020-01-31 10:32:37 -03:00
Felipe Zimmerle	fe98ce4c7d	Cosmetics: address cppcheck warnings	2020-01-30 18:19:34 -03:00
Felipe Zimmerle	86a5f471a9	Cosmetics: fixed static analysis issues.	2020-01-15 20:35:59 -03:00
Felipe Zimmerle	eeec7efb68	Renames collection::Variable to VariableValue	2018-02-20 13:40:01 -03:00
Felipe Zimmerle	7ac6bf7241	Fix memory issues while resolving variables	2017-08-27 22:06:20 -03:00
Felipe Zimmerle	4ad3574cf2	Adds offset regression tests and assorted fixes on var's offsets	2017-03-06 15:02:02 -03:00
Felipe Zimmerle	d851699529	Adds references to the collection variables	2017-03-06 15:02:00 -03:00
Felipe Zimmerle	e95efa05cc	Fix assorted memory and static analysis errors	2017-03-06 15:02:00 -03:00
Felipe Zimmerle	f2d149fc5f	Extends the direct access model to other collections	2017-03-06 15:02:00 -03:00