Ervin Hegedus
cddd9a7eb5
Fix build error if -Werror=format-security is presented
2024-09-03 21:49:43 +02:00
Marc Stern
6be2ee534a
Fixed ap_log_perror() usage
...
Replaces #3236
2024-08-26 17:17:36 +02:00
Ervin Hegedus
f65415ae8a
Merge pull request #3191 from marcstern/v2/pr/mem_leak_re
...
Memory leaks + enhanced logging
2024-08-26 16:37:01 +02:00
Marc Stern
046d3eb3ec
Fixed two error messages
2024-08-19 14:19:05 +02:00
Ervin Hegedus
e7e11d972f
Merge pull request #3202 from marcstern/v2/pr/assert
...
Fixed assert() usage
2024-08-18 22:58:06 +02:00
Marc Stern
e5bbd89399
re-added some NULL check at run-time, with an error message on stderr
2024-08-14 13:53:52 +02:00
Marc Stern
d32c8f1ad8
Fixed invalid logging
2024-08-12 17:06:35 +02:00
Marc Stern
7c379c8d59
Fixed assert() usage:
...
- added some missing
- removed some invalid
- removed some that were not relevant in the context of the current function, when done in a called function
2024-07-31 11:17:36 +02:00
Marc Stern
73a79af593
Fixed duplicate log entry
...
use ap_log_error() if msr is NULL
Fixed indentation
2024-07-25 08:55:26 +02:00
Marc Stern
b53c2277d7
removed duplicate log entry
2024-07-25 08:39:44 +02:00
Marc Stern
cd65a44d64
Removed useless code
2024-07-22 16:53:58 +02:00
Marc Stern
a32b512a7f
Systematically log problems in update_rule_target_ex().
...
Fix some memory leaks in update_rule_target_ex().
2024-07-22 15:59:28 +02:00
Marc Stern
5122f89005
defined id_log() only once
2024-04-16 13:28:37 +02:00
Marc Stern
a01b9b527e
minor fixes
2024-04-10 14:04:34 +02:00
Marc Stern
5f938536a0
fixed a NULL check
2024-04-08 11:01:29 +02:00
Marc Stern
649aea7288
Merge branch 'v2/master' into v2/mst/nullcheck2
2024-04-04 16:08:59 +02:00
Marc Stern
518b8ba6ab
more null pointer checks
2024-04-04 16:01:51 +02:00
Marc Stern
538ffa6baa
Added some null pointer checks.
...
Added a design doc.
2024-04-04 15:45:55 +02:00
Marc Stern
91da5872c1
Many null pointer checks
2024-02-20 13:15:52 +01:00
Ervin Hegedus
5cbd7e6e6c
Revert "Double memory allocation"
2024-02-07 23:09:59 +01:00
Ervin Hegedus
7eabbb2b72
Revert " Fix for DEBUG_CONF compile flag"
2024-02-07 23:09:34 +01:00
Ervin Hegedus
7828c63205
Revert "Fixed 2 memory leaks"
2024-02-07 23:09:05 +01:00
Ervin Hegedus
d778fbf8b7
Revert "Ignore (consistently) empty actions"
2024-02-07 23:06:16 +01:00
Ervin Hegedus
43cb827084
Revert "ctl:ruleRemoveByTag isn't executed if no rule id is present in the rule"
2024-02-07 23:05:28 +01:00
Ervin Hegedus
c3688dd8c4
Revert "Add context info to error message"
2024-02-07 23:04:47 +01:00
Marc Stern
17b76b9fa9
Merge pull request #2997 from marcstern/v2/mst/target_log
...
Add context info to error message
2024-02-01 11:20:43 +01:00
Marc Stern
710cc994b9
Merge pull request #3012 from marcstern/v2/mst/except_noid
...
ctl:ruleRemoveByTag isn't executed if no rule id is present in the rule
2024-02-01 11:18:54 +01:00
Marc Stern
aac0bee2ea
Merge pull request #3003 from marcstern/v2/mst/empty_action
...
Ignore (consistently) empty actions
2024-02-01 11:18:27 +01:00
Marc Stern
b354c71403
Merge pull request #2960 from marcstern/v2/mst/mem_leak1
...
Fixed 2 memory leaks
2024-02-01 10:53:58 +01:00
Marc Stern
8f3ef37ed8
Merge pull request #2963 from marcstern/v2/mst/debug_conf
...
Fix for DEBUG_CONF compile flag
2024-02-01 10:53:09 +01:00
Marc Stern
bacb0f3d76
Revert "avoid useless loops"
...
This reverts commit 9977870bc57e6cfe2a2bdfb64456abafeb1c5f2d.
2023-11-02 13:30:16 +01:00
Marc Stern
a6d3397b51
removeByTag wasn't executed if no rule id is present in the rule
2023-11-02 13:21:39 +01:00
Marc Stern
285f7efdfa
avoid useless loops
2023-10-31 13:01:19 +01:00
Marc Stern
9977870bc5
avoid useless loops
2023-10-31 12:55:07 +01:00
Marc Stern
6a24bc47d5
Ignore empty action instead of storing it
2023-10-26 09:22:22 +02:00
Marc Stern
5c9d8cd776
Add context info to error message
2023-10-17 14:06:56 +02:00
Marc Stern
18efc80bdd
Double memory allocation:
...
'current_targets' is allocated in ruleset->mp.
'rule->p1' is a copy of current_targets, but we strdup it in the same memory pool as 'current_targets'.
So, simply assign 'current_targets' to 'rule->p1'.
2023-08-21 10:30:36 +02:00
Marc Stern
eab780e992
typo
2023-08-21 10:01:46 +02:00
Marc Stern
82c69ccf49
Fix for DEBUG_CONF compile flag
2023-08-16 08:50:09 +02:00
Marc Stern
541707c0aa
removed useless code
2023-08-16 08:28:12 +02:00
Marc Stern
25a60e259a
Fixed 2 memory leaks
2023-08-16 08:25:50 +02:00
Erki Aring
b5130acb45
Move APLOG_USE_MODULE out of modsecurity.h
2022-11-15 17:31:18 +02:00
Victor Hora
96756533ba
Code cosmetics: Minor change to match commit 2a42cc
2018-09-22 20:40:30 -04:00
Victor Hora
aab128f810
Code cosmetics: checks if actionset is not null before use it
2018-09-22 20:21:23 -04:00
Daniel Stelter-Gliese
72f632e9b6
Avoid additional operator invokation if last transform of a multimatch doesn't modify the input
...
Fixes #1086
2017-05-22 15:13:54 -03:00
Felipe Zimmerle
caadf97524
Cosmetics: Fix 0x0bdda1 indentation issues
2017-05-03 09:34:47 -03:00
Marc Stern
51f312736a
rule id is not logged in case rule has no msg
2017-05-03 09:20:32 -03:00
Felipe Zimmerle
45b7706f1f
Adds sanity check before print action message in the logs
...
This is a sanity check on top of #1379
2017-04-11 10:04:19 -03:00
Marc Stern
99eb07d944
Fix missing rule id in log See https://github.com/SpiderLabs/ModSecurity/issues/391
2017-04-10 12:28:38 -03:00
Marc Stern
c1c91e24cd
{dis|en}able-filename-logging: Option to disable logging of filename in audit log [Issue #1065 - Marc Stern]
2017-04-07 10:55:08 -03:00
