github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-13 21:36:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Removed unused overload of dash_if_empty that sonarcloud flags as potential buffer overflow

Browse Source
This commit is contained in:
Eduardo Arias 2024-08-09 14:02:40 -07:00
parent 8b17f3691f
commit cc0f893854
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/transaction.cc
View File

@ -1520,7 +1520,7 @@ std::string Transaction::toOldAuditLogFormatIndex(const std::string &filename,
ss << utils::string::dash_if_empty(
m_variableRequestHeaders.resolveFirst("Host").get())
<< " ";
ss << utils::string::dash_if_empty(this->m_clientIpAddress->c_str()) << " ";
ss << utils::string::dash_if_empty(this->m_clientIpAddress.get()) << " ";
/** TODO: Check variable */
variables::RemoteUser *r = new variables::RemoteUser("REMOTE_USER");
std::vector<const VariableValue *> l;
@ -1531,7 +1531,7 @@ std::string Transaction::toOldAuditLogFormatIndex(const std::string &filename,
delete r;
ss << utils::string::dash_if_empty(
m_variableRemoteUser.c_str());
&m_variableRemoteUser);
ss << " ";
/** TODO: Check variable */
//ss << utils::string::dash_if_empty(

9
src/utils/string.h
View File

@ -75,15 +75,6 @@ inline std::string dash_if_empty(const std::string *str) {
}
inline std::string dash_if_empty(const char *str) {
if (str == NULL || std::strlen(str) == 0) {
return "-";
}
return std::string(str);
}
inline std::string limitTo(int amount, const std::string &str) {
std::string ret;