Replace the 2.5.1-rc1 tag for release.

CHANGES

@@ -1,6 +1,9 @@
-04 Mar 2008 - 2.5.1-rc1
+07 Mar 2008 - 2.5.1-rc1
 -----------------------
 
+ * Fixed an issue where a match would not occur if transformation caching
+   was enabled.
+
  * Using "severity" in a default action is now just a warning.
 
  * Cleaned up the "make test" target to better locate headers/libraries.

apache2/re.c

@@ -735,6 +735,8 @@ void msre_engine_destroy(msre_engine *engine) {
  * transaction phase.
  */
 #if defined(PERFORMANCE_MEASUREMENT)
+static apr_status_t msre_ruleset_process_phase_(msre_ruleset *ruleset, modsec_rec *msr);
+
 apr_status_t msre_ruleset_process_phase(msre_ruleset *ruleset, modsec_rec *msr) {
     apr_array_header_t *arr = NULL;
     msre_rule **rules = NULL;
@@ -1986,6 +1988,8 @@ static apr_status_t msre_rule_process_normal(msre_rule *rule, modsec_rec *msr) {
                     return -1;
                 }
                 if (rc == RULE_MATCH) {
+                    match_count++;
+
                     /* Return straight away if the transaction
                      * was intercepted - no need to process the remaining
                      * targets.

doc/modsecurity2-apache-reference.xml

@@ -4,7 +4,7 @@
   Manual</title>
 
   <articleinfo>
-    <releaseinfo>Version 2.5.1-rc1 (March 04, 2008)</releaseinfo>
+    <releaseinfo>Version 2.5.1-rc1 (March 07, 2008)</releaseinfo>
 
     <copyright>
       <year>2004-2008</year>
@@ -4606,14 +4606,26 @@ SecRule ARGS "attack" <emphasis>multiMatch</emphasis></programlisting>
 
       <para><emphasis>Action Group:</emphasis> Disruptive</para>
 
-      <para>Example:</para>
+      <para>Example1:</para>
 
       <programlisting format="linespecific">SecRule REQUEST_HEADERS:User-Agent "Test" log,<emphasis>pass</emphasis></programlisting>
 
+      <para>When using <emphasis>pass</emphasis> with SecRule with multiple
+      targets, <emphasis>all</emphasis> targets will be processed and
+      <emphasis>all</emphasis> non-disruptive actions will trigger for
+      <emphasis>every</emphasis> match found. In the second example the
+      TX:test target would be incremented by 1 for each matching
+      argument.</para>
+
+      <para>Example2:</para>
+
+      <programlisting format="linespecific">SecRule ARGS "test" log,<emphasis>pass</emphasis>,setvar:TX.test=+1</programlisting>
+
       <para><emphasis>Note</emphasis></para>
 
-      <para>Transaction will not be interrupted but it will be logged (unless
-      logging has been suppressed).</para>
+      <para>The transaction will not be interrupted but a log will be
+      generated for each matching target (unless logging has been
+      suppressed).</para>
     </section>
 
     <section>