github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-13 13:26:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change some parms to const reference (satisfies cppcheck)

Browse Source
This commit is contained in:
Martin Vierula 2022-04-27 08:57:09 -07:00
parent 0be89cc15e
commit 606f5721c2
No known key found for this signature in database
GPG Key ID: F2FC4E45883BCBA4
6 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
headers/modsecurity/transaction.h
View File

@ -399,7 +399,7 @@ class Transaction : public TransactionAnchoredVariables, public TransactionSecMa
size_t getRequestBodyLength();
#ifndef NO_LOGS
void debug(int, std::string) const;
void debug(int, const std::string&) const;
#endif
void serverLog(std::shared_ptr<RuleMessage> rm);

2
src/operators/operator.cc
View File

@ -138,7 +138,7 @@ bool Operator::evaluate(Transaction *transaction, const std::string& a) {
return true;
}
Operator *Operator::instantiate(std::string op, std::string param_str) {
Operator *Operator::instantiate(const std::string& op, const std::string& param_str) {
std::string op_ = utils::string::tolower(op);
std::unique_ptr<RunTimeString> param(new RunTimeString());
param->appendText(param_str);

3
src/operators/operator.h
View File

@ -101,7 +101,8 @@ class Operator {
}
virtual ~Operator() { }
static Operator *instantiate(std::string opName, std::string param);
static Operator *instantiate(const std::string& opName,
const std::string& param);
virtual bool init(const std::string &arg, std::string *error) {
return true;

2
src/transaction.cc
View File

@ -278,7 +278,7 @@ Transaction::~Transaction() {
*
*/
#ifndef NO_LOGS
void Transaction::debug(int level, std::string message) const {
void Transaction::debug(int level, const std::string& message) const {
if (m_rules == NULL) {
return;
}

2
src/variables/tx.h
View File

@ -99,7 +99,7 @@ class Tx_DynamicElement : public Variable {
}
static void storeOrUpdateFirst(Transaction *t, const std::string &var,
std::string value) {
const std::string &value) {
t->m_collections.m_tx_collection->storeOrUpdateFirst(var, value);
}

3
test/cppcheck_suppressions.txt
View File

@ -61,10 +61,7 @@ ctunullpointer:src/rule_with_operator.cc:135
ctunullpointer:src/rule_with_operator.cc:95
passedByValue:src/variables/global.h:109
passedByValue:src/variables/global.h:110
passedByValue:src/variables/tx.h:102
passedByValue:src/operators/operator.cc:141
passedByValue:src/parser/driver.cc:45
passedByValue:src/transaction.cc:281
passedByValue:src/utils/system.cc:154
passedByValue:src/utils/system.cc:166
passedByValue:test/common/modsecurity_test.cc:49