472 Commits

Author SHA1 Message Date
gtsoul-tech
fc272868b8 fixes left_id and suffix_id 2024-05-13 13:04:57 +03:00
gtsoul-tech
0b8e863282 more fixes 2024-05-13 12:41:40 +03:00
gtsoul-tech
2fa7eaded4 fix 2024-05-13 09:29:40 +03:00
gtsoul-tech
5affdf3a11 Merge branch 'develop' into bugFix/cppcheckError-noexplicitConstructor 2024-05-13 09:13:28 +03:00
gtsoul-tech
753c7de002 Merge branch 'develop' into test-noExplicitConstructor 2024-05-10 12:46:44 +03:00
gtsoul-tech
94b17ecaf2 noExplicitConstructor 2024-05-10 10:07:47 +03:00
G.E
4ff92f87d9 remove test comment 2024-05-09 15:12:02 +03:00
g. economou
cc63087d06
Merge branch 'develop' into wip-isildur-g-cppcheck66 2024-05-09 10:28:25 +03:00
G.E
8499055605 test comment 2024-05-09 00:12:30 +03:00
G.E
c38bb8bc1d one more fixed that had been missed. 2024-05-08 12:33:22 +03:00
Konstantinos Margaritis
7dd2135b80
Merge pull request #264 from gtsoul-tech/bugFix/cppcheck-constVariablePointer
Cppcheck constVariablePointer error
2024-05-08 10:28:24 +03:00
G.E
82cf36724e maybe fix broken merge 2024-05-05 18:26:20 +03:00
G.E
bb056ab63f just a dummy commit to test something 2024-05-05 12:11:17 +03:00
g. economou
13e5183be2
Merge branch 'develop' into wip-isildur-g-cppcheck66 2024-05-02 18:37:46 +03:00
G.E
c7f7d17ebc addressing cppcheck shadowFunction warnings 2024-05-02 18:00:03 +03:00
Konstantinos Margaritis
692a63c8ca
Merge pull request #263 from gtsoul-tech/bug/cppcheck-61
Cppcheck knownConditionTrueFalse error
2024-05-02 16:50:16 +03:00
gtsoul-tech
5ad1f2127f constVariablePointer 2024-05-02 14:30:18 +03:00
gtsoul-tech
a634d57b2d knownConditionTrueFalse fixes previously fp 2024-05-02 10:13:55 +03:00
gtsoul-tech
389b55c647 refactor bool to void setDistinctTops setDistinctRoseTops
setDistinctSuffixTops
2024-05-01 15:21:36 +03:00
gtsoul-tech
ea420114a7 knownConditionTrueFalse 2024-05-01 13:04:51 +03:00
G.E
d3dd448641 the merge got screwed up, this should fix it 2024-05-01 11:22:32 +03:00
g. economou
727cff3621
Merge branch 'develop' into wip-isildur-g-cppcheck-47-48-58 2024-05-01 10:59:59 +03:00
G.E
9902ca0e34 addressing 47 [constParameterReference],48 [constVariableReference],58
[constVariable]
2024-05-01 10:54:15 +03:00
gtsoul-tech
b5bf3d8d31 unreadVariable 2024-04-30 13:36:39 +03:00
Konstantinos Margaritis
2921e50ecc
Merge pull request #259 from gtsoul-tech/bug/cppcheckErrors
Bug/cppcheck errors (32,35) WIP
2024-04-30 10:27:47 +03:00
gtsoul-tech
bb6464431f new variableScope 2024-04-29 15:09:55 +03:00
G.E
2a476df2c5 fixed const adjustments. 2024-04-29 13:38:35 +03:00
gtsoul-tech
987cd17160 variableScope 2024-04-29 13:13:07 +03:00
G.E
7fd45f864c next batch for cppeheck, addressing syntaxError and
constParameterPointer
2024-04-24 17:32:09 +03:00
Konstantinos Margaritis
db07cddaec
Merge pull request #255 from isildur-g/wip-isildur-g
addressing some cppcheck warnings.
2024-04-24 12:39:17 +03:00
G.E
8dabc86a69 removed commented lines. 2024-04-23 23:46:08 +03:00
G.E
01dee390a9 ddressing some cppcheck warnings. yes this will be cleaned up in a
following commit. tests pass.
2024-04-23 19:08:24 +03:00
gtsoul-tech
52b0076f4f accessMoved 2024-04-23 14:49:10 +03:00
gtsoul-tech
c4bffd7cef accessMoved cppcheck error 2024-04-23 12:15:12 +03:00
G.E.
b0916df825 one more place to fix where clang in bsd is more picky than gcc in linux 2024-04-15 11:44:22 +03:00
Konstantinos Margaritis
9fac2bf78d remove unused constant 2024-01-17 17:13:51 +02:00
Konstantinos Margaritis
0d2f9ccbaa Fix 'unqualified call to std::move' errors in clang 15+ 2023-10-03 20:24:39 +03:00
Hong, Yang A
978105a4c0 klocwork: fix risk issues 2023-09-05 13:45:33 +03:00
Azat Khuzhin
07305d18ae Fix use-of-uninitialized-value due to getData128()
When temporary buffer is used in getData128(), then it may return
uninitialized data.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-12 23:13:34 +02:00
Robert Schulze
8f26c5e65f
Fix compilation with libcxx 16
After upgrading our (ClickHouse's) libcxx from 15 to 16, the compiler
started to complain about usage of an incomplete type "RoseInstruction"
in this (header) function:

  void RoseProgram::replace(Iter it, std::unique_ptr<RoseInstruction> ri) {
    ...

The reason is that libcxx 16 is the first version which implements C++23
constexpr std::unique_ptr (P2273R3, see (*)). RoseProgram::replace()
happens to be be const-evaluatable and the compiler tries to run
std::unique_ptr's ctor + dtor. This fails because at this point
RoseInstruction isn't defined yet.

There are two ways of fixing this:
1. Include rose_build_instruction.h (which contains RoseInstruction)
   into rose_build_program.h. Disadvantage: The new include will
   propagate transitively into all callers.
2. Move the function implementation into the source file which sees
   RoseInstruction's definition already. Disadvantage: Template
   instantiation is no longer automatic, instead there must be either a)
   explicit template instantiation (e.g. in rose_build_program.cpp) or
   b) all callers which instantiate the function must live in the same
   source file and do the instantiations by themselves. Fortunately, the
   latter is the case here, but potential future code outside
   rose_build_program.cpp will require ugly explicit instantiation.

(*) https://en.cppreference.com/w/cpp/23
2023-03-28 21:58:44 +00:00
Konstantinos Margaritis
6de45b4648 clang 14 complains about this, needs investigation 2022-09-16 14:02:26 +03:00
Hong, Yang A
decabdfede update year for bugfix #302-#305 2022-08-29 15:03:11 +03:00
Hong, Yang A
cafd5248b1 literal API: add instruction support
fixes github issue #303
2022-08-29 15:02:59 +03:00
BigRedEye
6d6c291769
fix: Mark operator bool explicit 2022-02-08 00:22:23 +03:00
Konstantinos Margaritis
08357a096c remove Windows/ICC support 2021-10-12 11:51:34 +03:00
George Wort
a879715953 Move SVE functions into their own files.
Change-Id: I995ba4b7d2b558ee403693ee45d747d414d3b177
2021-10-12 11:51:34 +03:00
George Wort
25183089fd Use SVE shufti for counting miracles.
Change-Id: Idd4aaf5bbc05fc90e9138c6fed385bc6ffa7b0b8
2021-10-12 11:51:34 +03:00
George Wort
56ef2d5f72 Use SVE2 for counting miracles.
Change-Id: I048dc182e5f4e726b847b3285ffafef4f538e550
2021-10-12 11:51:34 +03:00
George Wort
df926ef62f Implement new Vermicelli16 acceleration functions using SVE2.
The scheme utilises the MATCH and NMATCH instructions to
scan for 16 characters at the same rate as vermicelli
scans for one.

Change-Id: Ie2cef904c56651e6108593c668e9b65bc001a886
2021-10-12 11:51:34 +03:00
Konstantinos Margaritis
e35b88f2c8 use STL make_unique, remove wrapper header, breaks C++17 compilation 2021-10-12 11:51:34 +03:00