Commit Graph

279 Commits

Author SHA1 Message Date
Konstantinos Margaritis
7737104585 Bugfix/fix avx512vbmi regressions (#335)
Multiple AVX512VBMI-related fixes:

src/nfa/mcsheng_compile.cpp: No need for an assert here, impl_id can be set to 0
src/nfa/nfa_api_queue.h: Make sure this compiles on both C++ and C
src/nfagraph/ng_fuzzy.cpp: Fix compilation error when DEBUG_OUTPUT=on
src/runtime.c: Fix crash when data == NULL
unit/internal/sheng.cpp: Unit test has to enable AVX512VBMI manually as autodetection does not get trigger, this causes test to fail
src/fdr/teddy_fat.cpp: AVX512 loads need to be 64-bit aligned, caused a crash on clang-18
2025-05-30 21:08:55 +03:00
Konstantinos Margaritis
7b505226ed Various cppcheck fixes (#337) 2025-05-30 12:27:28 +03:00
Rafał Dowgird
4f40db0755 Fixed out of bounds read in AVX512VBMI version of fdr_exec_fat_teddy … (#333)
Fixed out of bounds read in AVX512VBMI version of fdr_exec_fat_teddy (#322)

  * Replaced the 32 byte read with a properly truncated mapped read
  * Added a unit test

Co-authored-by: Rafał Dowgird <rafal.dowgird@rtbhouse.com>
2025-05-18 11:01:10 +03:00
gtsoul-tech
50bcb90f8d Fix regression error #317 and add unit test (#318)
Revert the code that produced the regression error in #317 
Add the regression error to a unit test regressions.cpp along with the rebar tests

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-11-13 10:43:23 +02:00
gtsoul-tech
79b016a6e8 Cppcheck errors fixed and suppressed (#319)
* supress knownConditionTrueFalse

* cppcheck suppress redundantInitialization

* cppcheck solve stlcstrStream

* cppcheck suppress useStlAlgorithm

* cppcheck-suppress derefInvalidIteratorRedundantCheck

* cppcheck solvwe constParameterReference

* const parameter reference cppcheck

* removed wrong fix

* cppcheck-suppress memsetClassFloat

* cppcheck fix memsetClassFloat

* cppcheck fix unsignedLessThanZero

* supressing all errors on simde gitmodule

* fix typo (unsignedLessThanZero)

* fix cppcheck suppress simde gitmodule

* cppcheck-suppress unsignedLessThanZero

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-11-12 10:01:11 +02:00
gtsoul-tech
dbb830acd1 Bug fix/rebar tests (#307)
* fixed paths and utf8-lossy=true

* revert to maskz (its the bug)

* cppcheck fix

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-07-29 11:49:25 +03:00
gtsoul-tech
ca568477a8 Rebar based Unit tests (#305)
* rebar based unit tests

* fixing paths

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-07-24 10:39:24 +03:00
gtsoul-tech
30dd577126 Bug fix/clang-tidy-performance (#300)
Various clang-tidy-performance fixes:
* noexcept
* performance-noexcept-swap
* performance
* performance-move-const-arg
* performance-unnecessary-value-param
* performance-inefficient-vector-operation
* performance-no-int-to-ptr
* add performance
* performance-inefficient-string-concatenation
* clang-analyzer-deadcode.DeadStores
* performance-inefficient-vector-operation
* clang-analyzer-core.NullDereference
* clang-analyzer-core.UndefinedBinaryOperatorResult
* clang-analyzer-core.CallAndMessage

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-06-20 14:57:19 +03:00
Konstantinos Margaritis
79443a96f4 Fix Clang Tidy warnings (#295)
Fixes some of the clang-tidy warnings
clang-analyzer-deadcode.DeadStores
clang-analyzer-cplusplus.NewDelete
clang-analyzer-core.uninitialized.UndefReturn

closes some:#253

ignored in this pr:
/usr/include/boost/smart_ptr/detail/shared_count.hpp:432:24
/usr/include/boost/smart_ptr/detail/shared_count.hpp:443:24
51 in build/src/parser
gtest ones
src/fdr/teddy_compile.cpp:600:5 refactoring on way
src/fdr/fdr_compile.cpp:209:5 refactoring on way
2024-05-31 18:23:16 +03:00
gtsoul-tech
829b2d75fd remove comment 2024-05-31 09:47:45 +03:00
gtsoul-tech
a846d496b4 deadcode.DeadStores 2024-05-30 16:40:18 +03:00
gtsoul-tech
a2071582d5 optin.performance.Padding 2024-05-27 15:41:57 +03:00
Konstantinos Margaritis
02fc8e3b1c Fix/Suppress remaining Cppcheck warnings (#291)
Fix/suppress the following cppcheck warnings:

* arithOperationsOnVoidPointer
* uninitMember
* const*
* shadowVariable
* assignmentIntegerToAddress
* containerOutOfBounds
* pointer-related warnings in Ragel source
* missingOverride
* memleak
* knownConditionTrueFalse
* noExplicitConstructor
* invalidPrintfArgType_sint
* useStlAlgorithm
* cstyleCast
* clarifyCondition
* VSX-related cstyleCast
* unsignedLessThanZero 

Furthermore, we added a suppression list to be used, which also includes the following:
* missingIncludeSystem
* missingInclude
* unmatchedSuppression
2024-05-27 12:23:02 +03:00
Yoan Picchi
7054378c93 Speed up truffle with 256b TBL instructions
256b wide SVE vectors allow some simplification of truffle.
Up to 40% speedup on graviton3. Going from 12500 MB/s to 17000 MB/s
onhe microbenchmark.
SVE2 also offer this capability for 128b vector with a speedup around
25% compared to normal SVE

Add unit tests and benchmark for this wide variant

Signed-off-by: Yoan Picchi <yoan.picchi@arm.com>
2024-05-22 16:13:53 +00:00
Konstantinos Margaritis
1fc353efa6 Merge pull request #283 from isildur-g/wip-cppcheck271-part2
Wip cppcheck271 useStlAlgorithm part2
2024-05-21 15:52:15 +03:00
Konstantinos Margaritis
b07f527f2e Add more C style casts fixes and suppressions 2024-05-18 21:49:54 +03:00
Konstantinos Margaritis
648b655734 Merge pull request #285 from gtsoul-tech/bugFix/cppcheck-cStylecasts-Part3
Part 3 of C-style cast cppcheck
2024-05-18 09:43:25 +03:00
gtsoul-tech
d8f61b0d66 cStyleCasts 2024-05-17 16:58:08 +03:00
gtsoul-tech
037a54bb39 cStyleCasts 2024-05-17 13:57:12 +03:00
g. economou
45de972f44 Merge branch 'develop' into wip-cppcheck271-part2 2024-05-17 11:08:09 +03:00
G.E
6c4e027e26 next batch 2024-05-17 10:44:28 +03:00
Konstantinos Margaritis
7f13bc24aa remove unused variables 2024-05-15 17:18:53 +03:00
Konstantinos Margaritis
4bb3f4445f Fix unreadVariable warning 2024-05-15 17:05:50 +03:00
gtsoul-tech
efa376838d explicit constructor Supervector 2024-05-14 13:32:50 +03:00
gtsoul-tech
490c16471b most ptr.get() conversion 2024-05-13 14:24:16 +03:00
gtsoul-tech
b3a9366442 Merge branch 'develop' into test-noExplicitConstructor 2024-05-10 12:46:44 +03:00
gtsoul-tech
a91a610651 noExplicitConstructor 1 more 2024-05-10 10:08:14 +03:00
gtsoul-tech
1986280b41 noExplicitConstructor 2024-05-10 10:07:47 +03:00
Konstantinos Margaritis
edd9b9e4e1 Merge pull request #264 from gtsoul-tech/bugFix/cppcheck-constVariablePointer
Cppcheck constVariablePointer error
2024-05-08 10:28:24 +03:00
Konstantinos Margaritis
851de33405 Merge pull request #263 from gtsoul-tech/bug/cppcheck-61
Cppcheck knownConditionTrueFalse error
2024-05-02 16:50:16 +03:00
gtsoul-tech
2903681129 constVariablePointer 2024-05-02 14:30:18 +03:00
gtsoul-tech
51ce67be3d knownConditionTrueFalse fixes previously fp 2024-05-02 10:13:55 +03:00
g. economou
583e1d576a Merge branch 'develop' into wip-isildur-g-cppcheck-47-48-58 2024-05-01 10:59:59 +03:00
G.E
98243a6a08 addressing 47 [constParameterReference],48 [constVariableReference],58
[constVariable]
2024-05-01 10:54:15 +03:00
Konstantinos Margaritis
46aba61156 Merge pull request #239 from ypicchi-arm/feature/add-sheng-unit-tests
Feature/add sheng unit tests
2024-05-01 00:07:14 +03:00
Yoan Picchi
d0325401f2 Add sheng tests
Signed-off-by: Yoan Picchi <yoan.picchi@arm.com>
2024-04-30 14:34:14 +00:00
gtsoul-tech
c38a44fd2f unreadVariable 2024-04-30 13:36:39 +03:00
Konstantinos Margaritis
bfc4276453 Merge pull request #259 from gtsoul-tech/bug/cppcheckErrors
Bug/cppcheck errors (32,35) WIP
2024-04-30 10:27:47 +03:00
Konstantinos Margaritis
fe89b434e8 Merge pull request #258 from isildur-g/wip-isildur-g-cppcheck1220
Wip cppcheck1220
2024-04-29 21:58:13 +03:00
gtsoul-tech
e22fe382ea new variableScope 2024-04-29 15:09:55 +03:00
G.E
5f94045a07 fixed const adjustments. 2024-04-29 13:38:35 +03:00
gtsoul-tech
9df8527e91 variableScope 2024-04-29 13:13:07 +03:00
G.E
68306ba75c next batch for cppeheck, addressing syntaxError and
constParameterPointer
2024-04-24 17:32:09 +03:00
gtsoul-tech
3ced2f7ebf shiftTooManyBitsSigned 2024-04-24 11:13:28 +03:00
gtsoul-tech
ba3603b285 uninitvar 2024-04-24 11:13:02 +03:00
gtsoul-tech
ca340c141e invalidPrintfArgType_sint 2024-04-24 11:07:23 +03:00
Konstantinos Margaritis
27726c2f6a Revert "fix more unused-variable warnings"
This reverts commit afb1a1705f.
2024-01-20 17:46:29 +02:00
Konstantinos Margaritis
5276f66b17 Revert "fix unused-variable warning"
This reverts commit ac02b589be.
2024-01-20 17:46:29 +02:00
Konstantinos Margaritis
cac6d8e14d Revert "don't demand 32/64-byte alignment if there is no 256/512-bit SIMD engine"
This reverts commit 719e1c9be6.
2024-01-19 17:41:40 +02:00
Konstantinos Margaritis
69b3b31345 -Wno-pass-failed is only for ppc64le 2024-01-19 11:23:17 +02:00