Commit Graph

447 Commits

Author SHA1 Message Date
gtsoul-tech
30dd577126 Bug fix/clang-tidy-performance (#300)
Various clang-tidy-performance fixes:
* noexcept
* performance-noexcept-swap
* performance
* performance-move-const-arg
* performance-unnecessary-value-param
* performance-inefficient-vector-operation
* performance-no-int-to-ptr
* add performance
* performance-inefficient-string-concatenation
* clang-analyzer-deadcode.DeadStores
* performance-inefficient-vector-operation
* clang-analyzer-core.NullDereference
* clang-analyzer-core.UndefinedBinaryOperatorResult
* clang-analyzer-core.CallAndMessage

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-06-20 14:57:19 +03:00
gtsoul-tech
999263d140 Bug fix/clang tidy warnings part2 (#296)
* core.StackAddressEscape

* cplusplus.VirtualCall

* clang-analyzer-deadcode.DeadStores

* clang-analyzer-core.NullDereference

* clang-analyzer-core.NonNullParamChecker

* change to nolint

---------

Co-authored-by: gtsoul-tech <gtsoulkanakis@gmail.com>
2024-06-04 16:18:17 +03:00
gtsoul-tech
b4a176738a clang-analyzer-core.uninitialized.UndefReturn 2024-05-31 10:24:44 +03:00
gtsoul-tech
120e896691 clang-analyzer-cplusplus.NewDelete 2024-05-30 16:40:55 +03:00
gtsoul-tech
793025fab6 uninitialized.UndefReturn 2024-05-29 11:51:06 +03:00
Konstantinos Margaritis
02fc8e3b1c Fix/Suppress remaining Cppcheck warnings (#291)
Fix/suppress the following cppcheck warnings:

* arithOperationsOnVoidPointer
* uninitMember
* const*
* shadowVariable
* assignmentIntegerToAddress
* containerOutOfBounds
* pointer-related warnings in Ragel source
* missingOverride
* memleak
* knownConditionTrueFalse
* noExplicitConstructor
* invalidPrintfArgType_sint
* useStlAlgorithm
* cstyleCast
* clarifyCondition
* VSX-related cstyleCast
* unsignedLessThanZero 

Furthermore, we added a suppression list to be used, which also includes the following:
* missingIncludeSystem
* missingInclude
* unmatchedSuppression
2024-05-27 12:23:02 +03:00
Yoan Picchi
7054378c93 Speed up truffle with 256b TBL instructions
256b wide SVE vectors allow some simplification of truffle.
Up to 40% speedup on graviton3. Going from 12500 MB/s to 17000 MB/s
onhe microbenchmark.
SVE2 also offer this capability for 128b vector with a speedup around
25% compared to normal SVE

Add unit tests and benchmark for this wide variant

Signed-off-by: Yoan Picchi <yoan.picchi@arm.com>
2024-05-22 16:13:53 +00:00
Konstantinos Margaritis
23e05ec443 Merge pull request #287 from gtsoul-tech/bugFix/cppcheck-cStylecasts-Part4
Part 4 of C-style cast cppcheck
2024-05-21 15:59:51 +03:00
Konstantinos Margaritis
1fc353efa6 Merge pull request #283 from isildur-g/wip-cppcheck271-part2
Wip cppcheck271 useStlAlgorithm part2
2024-05-21 15:52:15 +03:00
gtsoul-tech
d7dc3ec916 cstylecasts suppress,fixes 2024-05-20 17:09:30 +03:00
gtsoul-tech
cb8808619e fix cStyleCasts 2024-05-20 14:54:35 +03:00
Konstantinos Margaritis
b07f527f2e Add more C style casts fixes and suppressions 2024-05-18 21:49:54 +03:00
g. economou
45de972f44 Merge branch 'develop' into wip-cppcheck271-part2 2024-05-17 11:08:09 +03:00
G.E
6c4e027e26 next batch 2024-05-17 10:44:28 +03:00
G.E
d78cfb922e first batch of cppcheck disables and a few more stl-ifications,
involving use of accumulate() .
2024-05-16 23:01:17 +03:00
Konstantinos Margaritis
056cdc2dab Fix wrong cast in aligned_free() 2024-05-16 13:06:28 +03:00
Konstantinos Margaritis
e39db866ce Fix C-style casts 2024-05-16 12:03:42 +03:00
Konstantinos Margaritis
15950078c1 another duplicateExpression false positive 2024-05-15 17:11:07 +03:00
Konstantinos Margaritis
93239afa3a Merge pull request #277 from isildur-g/wip-cppcheck271
phase 1 of addressing cppcheck useStlAlgorithm warnings for fill and copy operations
2024-05-15 10:44:15 +03:00
G.E
b541288cd5 phase 1 of addressing cppcheck useStlAlgorithm warnings,
this set only includes fill and copy operations.
2024-05-14 17:37:38 +03:00
gtsoul-tech
0501f39277 supervector conversion 2024-05-14 14:15:15 +03:00
gtsoul-tech
0a90c30fa8 forgot some conversions SuperVector<32> 2024-05-14 14:10:56 +03:00
gtsoul-tech
efa376838d explicit constructor Supervector 2024-05-14 13:32:50 +03:00
gtsoul-tech
9cf735c0b2 ppc64el supervector explicit constructor 2024-05-14 10:11:52 +03:00
gtsoul-tech
91c2ab34e0 arm supervector explicit constructor 2024-05-14 09:53:08 +03:00
gtsoul-tech
a162722629 x86 explicit constructor supervector 2024-05-14 09:28:13 +03:00
gtsoul-tech
65cd281d48 revert supervector 2024-05-13 09:52:42 +03:00
gtsoul-tech
e8850987d0 Merge branch 'develop' into bugFix/cppcheckError-noexplicitConstructor 2024-05-13 09:13:28 +03:00
gtsoul-tech
b3a9366442 Merge branch 'develop' into test-noExplicitConstructor 2024-05-10 12:46:44 +03:00
gtsoul-tech
192c989283 supervector 2024-05-10 12:43:45 +03:00
gtsoul-tech
1986280b41 noExplicitConstructor 2024-05-10 10:07:47 +03:00
g. economou
3e395a9d1e Merge branch 'develop' into wip-isildur-g-cppcheck66 2024-05-09 10:28:25 +03:00
g. economou
c979e4ac11 Merge branch 'develop' into wip-isildur-g-cppcheck66 2024-05-02 18:37:46 +03:00
G.E
33f80d3261 addressing cppcheck shadowFunction warnings 2024-05-02 18:00:03 +03:00
gtsoul-tech
2903681129 constVariablePointer 2024-05-02 14:30:18 +03:00
g. economou
583e1d576a Merge branch 'develop' into wip-isildur-g-cppcheck-47-48-58 2024-05-01 10:59:59 +03:00
G.E
98243a6a08 addressing 47 [constParameterReference],48 [constVariableReference],58
[constVariable]
2024-05-01 10:54:15 +03:00
gtsoul-tech
e22fe382ea new variableScope 2024-04-29 15:09:55 +03:00
gtsoul-tech
9df8527e91 variableScope 2024-04-29 13:13:07 +03:00
gtsoul-tech
03e641a150 legacyUninitvar 2024-04-23 14:48:58 +03:00
gtsoul-tech
7d16877b24 useInitializationList 2024-04-23 14:47:21 +03:00
gtsoul-tech
7991aa364d clang-format revert 2024-04-17 13:55:42 +03:00
gtsoul-tech
d87a2fb2dc gcc-14 compilation fix Closes:#245 2024-04-17 13:33:48 +03:00
G.E.
b054e6c488 added copyright info for modified src files 2024-04-11 09:49:43 +03:00
G.E.
feeb6a57ac moved HAVE_BUILTIN_POPCOUNT def to cmake 2024-03-12 14:22:39 +02:00
G.E.
33444e7ce0 incremental improvement in cleanliness 2024-03-12 12:37:08 +02:00
G.E.
205bcbb060 support building on NetBSD 2024-03-06 10:48:56 +01:00
Konstantinos Margaritis
a4d1779945 Merge pull request #225 from VectorCamp/feature/cleanup-compiler-warnings
According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project. 

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.
2024-01-20 22:41:00 +02:00
Konstantinos Margaritis
7a2179c793 Revert "if we don't have a 256/512-bit SIMD engine, there is no need to have 32/64-byte alignment and gcc complains anyway"
This reverts commit 9134cd6250.
2024-01-19 15:23:11 +02:00
Yoan Picchi
6652d4a837 Make the match component of SVE truffle constant time
There are no significant speed up for 128b vectors but we expect some speedup
for wider vectors compared to the previous linear time implementation of the
match.hpp component

Signed-off-by: Yoan Picchi <yoan.picchi@arm.com>
2024-01-18 11:53:45 +00:00