Fix/Suppress remaining Cppcheck warnings (#291)

Fix/suppress the following cppcheck warnings:

* arithOperationsOnVoidPointer
* uninitMember
* const*
* shadowVariable
* assignmentIntegerToAddress
* containerOutOfBounds
* pointer-related warnings in Ragel source
* missingOverride
* memleak
* knownConditionTrueFalse
* noExplicitConstructor
* invalidPrintfArgType_sint
* useStlAlgorithm
* cstyleCast
* clarifyCondition
* VSX-related cstyleCast
* unsignedLessThanZero 

Furthermore, we added a suppression list to be used, which also includes the following:
* missingIncludeSystem
* missingInclude
* unmatchedSuppression

tools/hsbench/engine_chimera.h

@@ -55,7 +55,7 @@ struct CompileCHStats {
 class EngineCHContext : public EngineContext{
 public:
     explicit EngineCHContext(const ch_database_t *db);
-    ~EngineCHContext();
+    virtual ~EngineCHContext() override;
 
     ch_scratch_t *scratch = nullptr;
 };
@@ -64,7 +64,7 @@ public:
 class EngineChimera : public Engine {
 public:
     explicit EngineChimera(ch_database_t *db, CompileCHStats cs);
-    ~EngineChimera();
+    virtual ~EngineChimera() override;
 
     std::unique_ptr<EngineContext> makeContext() const override;
 

tools/hsbench/engine_hyperscan.h

@@ -56,7 +56,7 @@ struct CompileHSStats {
 class EngineHSContext : public EngineContext {
 public:
     explicit EngineHSContext(const hs_database_t *db);
-    ~EngineHSContext();
+    virtual ~EngineHSContext() override;
 
     hs_scratch_t *scratch = nullptr;
 };
@@ -64,7 +64,7 @@ public:
 /** Streaming mode scans have persistent stream state associated with them. */
 class EngineHSStream : public EngineStream {
 public:
-    ~EngineHSStream();
+    virtual ~EngineHSStream() override;
     hs_stream_t *id = nullptr;
     EngineHSContext *ctx = nullptr;
 };
@@ -73,7 +73,7 @@ public:
 class EngineHyperscan : public Engine {
 public:
     explicit EngineHyperscan(hs_database_t *db, CompileHSStats cs);
-    ~EngineHyperscan();
+    virtual ~EngineHyperscan() override;
 
     std::unique_ptr<EngineContext> makeContext() const override;
 

tools/hsbench/engine_pcre.h

@@ -54,7 +54,7 @@ struct CompilePCREStats {
 class EnginePCREContext : public EngineContext{
 public:
     explicit EnginePCREContext(int capture_cnt);
-    ~EnginePCREContext();
+    virtual ~EnginePCREContext() override;
 
     int *ovec = nullptr;
 };
@@ -72,7 +72,7 @@ class EnginePCRE : public Engine {
 public:
     explicit EnginePCRE(std::vector<std::unique_ptr<PcreDB>> dbs_in,
                         CompilePCREStats cs, int capture_cnt_in);
-    ~EnginePCRE();
+    virtual ~EnginePCRE() override;
 
     std::unique_ptr<EngineContext> makeContext() const override;
 

tools/hsbench/main.cpp

@@ -759,11 +759,9 @@ void displayResults(const vector<unique_ptr<ThreadContext>> &threads,
 
     // Sanity check: all of our results should have the same match count.
     for (const auto &t : threads) {
-        // cppcheck-suppress useStlAlgorithm
-        if (!all_of(begin(t->results), end(t->results),
-                    [&matchesPerRun](const ResultEntry &e) {
+        if (!all_of(begin(t->results), end(t->results), [&matchesPerRun](const ResultEntry &e) {
                         return e.matches == matchesPerRun;
-                    })) {
+                    })) { // cppcheck-suppress useStlAlgorithm
             printf("\nWARNING: PER-SCAN MATCH COUNTS ARE INCONSISTENT!\n\n");
             break;
         }
@@ -816,11 +814,9 @@ void displayCsvResults(const vector<unique_ptr<ThreadContext>> &threads,
 
     // Sanity check: all of our results should have the same match count.
     for (const auto &t : threads) {
-        // cppcheck-suppress useStlAlgorithm
-        if (!all_of(begin(t->results), end(t->results),
-                    [&matchesPerRun](const ResultEntry &e) {
+        if (!all_of(begin(t->results), end(t->results), [&matchesPerRun](const ResultEntry &e) {
                         return e.matches == matchesPerRun;
-                    })) {
+                    })) { // cppcheck-suppress useStlAlgorithm
             printf("\nWARNING: PER-SCAN MATCH COUNTS ARE INCONSISTENT!\n\n");
             break;
         }
@@ -871,11 +867,9 @@ void sqlResults(const vector<unique_ptr<ThreadContext>> &threads,
 
     // Sanity check: all of our results should have the same match count.
     for (const auto &t : threads) {
-        // cppcheck-suppress useStlAlgorithm
-        if (!all_of(begin(t->results), end(t->results),
-                    [&matchesPerRun](const ResultEntry &e) {
+        if (!all_of(begin(t->results), end(t->results), [&matchesPerRun](const ResultEntry &e) {
                         return e.matches == matchesPerRun;
-                    })) {
+                    })) { // cppcheck-suppress useStlAlgorithm
             printf("\nWARNING: PER-SCAN MATCH COUNTS ARE INCONSISTENT!\n\n");
             break;
         }
@@ -963,6 +957,7 @@ void runBenchmark(const Engine &db,
 
     for (unsigned i = 0; i < numThreads; i++) {
         auto t = makeThreadContext(db, corpus_blocks, i, sync_barrier);
+	// cppcheck-suppress knownConditionTrueFalse
         int core = useAffinity ? (int)threadCores[i] : -1;
         if (!t->start(core)) {
             printf("Unable to start processing thread %u\n", i);

tools/hsdump/main.cpp

@@ -143,7 +143,7 @@ void usage(const char *name, const char *error) {
 }
 
 static
-void processArgs(int argc, char *argv[], Grey &grey) {
+void processArgs(int argc, char *argv[], Grey &grey) { // cppcheck-suppress constParameterReference
     static const char *options = "d:De:E:G:hLNo:Ps:VXx:z:8";
     static struct option longOptions[] = {
         {"dump_db",             no_argument,        nullptr, 'D'},
@@ -294,7 +294,7 @@ void dumpDb(const struct hs_database *out, const Grey &grey) {
     size_t len = 0;
     hs_error_t err = hs_serialize_database(out, &bytes, &len);
     if (err != HS_SUCCESS) {
-        printf("ERROR: hs_serialize_database() failed with error %u\n", err);
+        printf("ERROR: hs_serialize_database() failed with error %d\n", err);
         return;
     }
 
@@ -331,7 +331,7 @@ void clearDir(const string &path) {
         exit(1);
     }
 
-    struct dirent *d_ent;
+    const struct dirent *d_ent;
     while (nullptr != (d_ent = readdir(dir))) {
         string name(d_ent->d_name);
         if (name == "." || name == "..") {
@@ -423,7 +423,7 @@ void dumpScratch(const hs_database_t *db, const Grey &grey) {
                    (grey.dumpPath + "scratch.txt").c_str(), strerror(errno));
         }
     } else {
-        printf("ERROR: hs_alloc_scratch() failed with error %u\n", err);
+        printf("ERROR: hs_alloc_scratch() failed with error %d\n", err);
     }
     hs_free_scratch(scratch);
 }
@@ -442,7 +442,7 @@ void dumpInfo(const hs_database_t *db, const Grey &grey) {
                    (grey.dumpPath + "db_info.txt").c_str(), strerror(errno));
         }
     } else {
-        printf("ERROR: hs_database_info() failed with error %u\n", err);
+        printf("ERROR: hs_database_info() failed with error %d\n", err);
     }
     free(info);
 }
@@ -482,7 +482,7 @@ unsigned int dumpDataMulti(const vector<const char *> &patterns,
         if (compile_err && compile_err->message) {
             printf("ERROR: Compile failed: %s\n", compile_err->message);
         } else {
-            printf("ERROR: hs_compile_multi_int() returned error %u", err);
+            printf("ERROR: hs_compile_multi_int() returned error %d", err);
         }
         hs_free_compile_error(compile_err);
         return 1;