diff --git a/src/nfa/repeat.c b/src/nfa/repeat.c index 5b2e4df4..07d02082 100644 --- a/src/nfa/repeat.c +++ b/src/nfa/repeat.c @@ -785,7 +785,7 @@ enum RepeatMatch repeatHasMatchRange(const struct RepeatInfo *info, if (diff > info->repeatMax) { DEBUG_PRINTF("range list is stale\n"); return REPEAT_STALE; - } else if (diff >= info->repeatMin && diff <= info->repeatMax) { + } else if (diff >= info->repeatMin) { return REPEAT_MATCH; } @@ -836,7 +836,7 @@ enum RepeatMatch repeatHasMatchBitmap(const struct RepeatInfo *info, if (diff > info->repeatMax) { DEBUG_PRINTF("stale\n"); return REPEAT_STALE; - } else if (diff >= info->repeatMin && diff <= info->repeatMax) { + } else if (diff >= info->repeatMin) { return REPEAT_MATCH; } diff --git a/src/rose/rose_build_bytecode.cpp b/src/rose/rose_build_bytecode.cpp index 639edddc..181d77e5 100644 --- a/src/rose/rose_build_bytecode.cpp +++ b/src/rose/rose_build_bytecode.cpp @@ -1495,7 +1495,7 @@ void findExclusiveInfixes(RoseBuildImpl &build, build_context &bc, } static -bool buildLeftfixes(RoseBuildImpl &tbi, build_context &bc, +void buildLeftfixes(RoseBuildImpl &tbi, build_context &bc, QueueIndexFactory &qif, set *no_retrigger_queues, set *eager_queues, bool do_prefix) { RoseGraph &g = tbi.g; @@ -1581,7 +1581,7 @@ bool buildLeftfixes(RoseBuildImpl &tbi, build_context &bc, leftfix); } - return true; + return ; } static @@ -2059,16 +2059,8 @@ bool buildNfas(RoseBuildImpl &tbi, build_context &bc, QueueIndexFactory &qif, suffixTriggers.clear(); *leftfixBeginQueue = qif.allocated_count(); - - if (!buildLeftfixes(tbi, bc, qif, no_retrigger_queues, eager_queues, - true)) { - return false; - } - - if (!buildLeftfixes(tbi, bc, qif, no_retrigger_queues, eager_queues, - false)) { - return false; - } + buildLeftfixes(tbi, bc, qif, no_retrigger_queues, eager_queues,true); + buildLeftfixes(tbi, bc, qif, no_retrigger_queues, eager_queues,false); return true; } diff --git a/unit/internal/fdr_flood.cpp b/unit/internal/fdr_flood.cpp index 77d3ff47..fd8a9734 100644 --- a/unit/internal/fdr_flood.cpp +++ b/unit/internal/fdr_flood.cpp @@ -154,7 +154,7 @@ TEST_P(FDRFloodp, NoMask) { struct hs_scratch scratch; scratch.fdr_conf = NULL; - while (1) { + while (c != 255) { SCOPED_TRACE((unsigned int)c); u8 bit = 1 << (c & 0x7); u8 cAlt = c ^ bit; @@ -233,9 +233,7 @@ TEST_P(FDRFloodp, NoMask) { } matchesCounts.clear(); - if (++c == 0) { - break; - } + ++c; } } @@ -248,7 +246,7 @@ TEST_P(FDRFloodp, WithMask) { struct hs_scratch scratch; scratch.fdr_conf = NULL; - while (1) { + while (c != 255) { u8 bit = 1 << (c & 0x7); u8 cAlt = c ^ bit; SCOPED_TRACE((unsigned int)c); @@ -396,9 +394,7 @@ TEST_P(FDRFloodp, WithMask) { } matchesCounts.clear(); - if (++c == '\0') { - break; - } + ++c; } } @@ -414,7 +410,7 @@ TEST_P(FDRFloodp, StreamingMask) { struct hs_scratch scratch; scratch.fdr_conf = NULL; - while (1) { + while (c != 255) { u8 bit = 1 << (c & 0x7); u8 cAlt = c ^ bit; SCOPED_TRACE((unsigned int)c); @@ -548,9 +544,7 @@ TEST_P(FDRFloodp, StreamingMask) { } } - if (++c == '\0') { - break; - } + ++c; } matchesCounts.clear(); } diff --git a/unit/internal/flat_set.cpp b/unit/internal/flat_set.cpp index 10607a6f..174a4771 100644 --- a/unit/internal/flat_set.cpp +++ b/unit/internal/flat_set.cpp @@ -48,9 +48,7 @@ std::ostream &operator<<(std::ostream &os, const flat_set &f) { os << "{"; for (auto it = begin(f); it != end(f); ++it) { os << *it; - if (it != end(f)) { - os << ", "; - } + os << ", "; } os << "}"; return os; diff --git a/unit/internal/insertion_ordered.cpp b/unit/internal/insertion_ordered.cpp index 6026ce1d..2d799aa9 100644 --- a/unit/internal/insertion_ordered.cpp +++ b/unit/internal/insertion_ordered.cpp @@ -149,9 +149,7 @@ std::ostream &operator<<(std::ostream &os, const insertion_ordered_set &s) { os << "{"; for (auto it = begin(s); it != end(s); ++it) { os << *it; - if (it != end(s)) { - os << ", "; - } + os << ", "; } os << "}"; return os;