replace push_back by emplace_back where possible

src/util/clique.cpp

@@ -51,7 +51,7 @@ vector<u32> getNeighborInfo(const CliqueGraph &g,
     // find neighbors for cv
     for (const auto &v : adjacent_vertices_range(cv, g)) {
         if (g[v].stateId != id && contains(group, g[v].stateId)){
-            neighbor.push_back(g[v].stateId);
+            neighbor.emplace_back(g[v].stateId);
             DEBUG_PRINTF("Neighbor:%u\n", g[v].stateId);
         }
     }
@@ -68,7 +68,7 @@ vector<u32> findCliqueGroup(CliqueGraph &cg) {
     vector<u32> init;
     for (const auto &v : vertices_range(cg)) {
         vertexMap[cg[v].stateId] = v;
-        init.push_back(cg[v].stateId);
+        init.emplace_back(cg[v].stateId);
     }
     gStack.push(init);
 
@@ -81,7 +81,7 @@ vector<u32> findCliqueGroup(CliqueGraph &cg) {
         // Choose a vertex from the graph
         u32 id = g[0];
         CliqueVertex &n = vertexMap.at(id);
-        clique.push_back(id);
+        clique.emplace_back(id);
         // Corresponding vertex in the original graph
         set<u32> subgraphId(g.begin(), g.end());
         auto neighbor = getNeighborInfo(cg, n, subgraphId);
@@ -110,7 +110,7 @@ vector<vector<u32>> removeClique(CliqueGraph &cg) {
         for (const auto &v : vertices_range(cg)) {
             u32 id = cg[v].stateId;
             if (find(c.begin(), c.end(), id) != c.end()) {
-                dead.push_back(v);
+                dead.emplace_back(v);
             }
         }
         for (const auto &v : dead) {
@@ -121,7 +121,7 @@ vector<vector<u32>> removeClique(CliqueGraph &cg) {
             break;
         }
         auto clique = findCliqueGroup(cg);
-        cliquesVec.push_back(clique);
+        cliquesVec.emplace_back(clique);
     }
 
     return cliquesVec;

src/util/determinise.h

@@ -88,7 +88,7 @@ bool determinise(Auto &n, std::vector<ds> &dstates, size_t state_limit,
     dstates.reserve(state_limit);
 
     dstate_ids.emplace(n.dead, DEAD_STATE);
-    dstates.push_back(ds(alphabet_size));
+    dstates.emplace_back(ds(alphabet_size));
     std::fill_n(dstates[0].next.begin(), alphabet_size, DEAD_STATE);
 
     std::queue<std::pair<StateSet, dstate_id_t>> q;
@@ -99,7 +99,7 @@ bool determinise(Auto &n, std::vector<ds> &dstates, size_t state_limit,
         q.emplace(init[i], dstates.size());
         assert(!contains(dstate_ids, init[i]));
         dstate_ids.emplace(init[i], dstates.size());
-        dstates.push_back(ds(alphabet_size));
+        dstates.emplace_back(ds(alphabet_size));
     }
 
     std::vector<StateSet> succs(alphabet_size, n.dead);
@@ -149,7 +149,7 @@ bool determinise(Auto &n, std::vector<ds> &dstates, size_t state_limit,
                 } else {
                     succ_id = dstate_ids.size();
                     dstate_ids.emplace(succs[s], succ_id);
-                    dstates.push_back(ds(alphabet_size));
+                    dstates.emplace_back(ds(alphabet_size));
                     dstates.back().daddy = n.unalpha[s] < N_CHARS ? curr_id : 0;
                     q.emplace(succs[s], succ_id);
                 }

src/util/graph.h

@@ -157,7 +157,7 @@ find_vertices_in_cycles(const Graph &g) {
     std::map<size_t, std::vector<vertex_descriptor>> comps;
 
     for (const auto &e : comp_map) {
-        comps[e.second].push_back(e.first);
+        comps[e.second].emplace_back(e.first);
     }
 
     flat_set<vertex_descriptor> rv;

src/util/insertion_ordered.h

@@ -163,7 +163,7 @@ public:
     std::pair<iterator, bool> insert(const Key &key, const Element &element) {
         const auto idx = data.size();
         if (map.emplace(key, idx).second) {
-            data.push_back(element);
+            data.emplace_back(element);
             return {begin() + idx, true};
         }
         return {end(), false};

src/util/multibit_build.cpp

@@ -112,13 +112,13 @@ void bfs(vector<mmbit_sparse_iter> &out, const TreeNode &tree) {
 
         if (depth != t->depth) {
             depth = t->depth;
-            levels.push_back(out.size());
+            levels.emplace_back(out.size());
         }
 
         DEBUG_PRINTF("pop: mask=0x%08llx, depth=%u, children.size()=%zu\n",
                      t->mask, t->depth, t->children.size());
 
-        out.push_back(mmbit_sparse_iter());
+        out.emplace_back(mmbit_sparse_iter());
         memset(&out.back(), 0, sizeof(mmbit_sparse_iter));
         mmbit_sparse_iter &record = out.back();
         record.mask = t->mask;

src/util/partitioned_set.h

@@ -139,9 +139,9 @@ public:
             }
 
             if (*sp_it > member) {
-                split_temp_diff.push_back(member);
+                split_temp_diff.emplace_back(member);
             } else {
-                split_temp_inter.push_back(member);
+                split_temp_inter.emplace_back(member);
             }
         }
 
@@ -177,7 +177,7 @@ public:
 
         /* smaller subset is placed in the new subset  */
         size_t new_index = subsets.size();
-        subsets.push_back(subset());
+        subsets.emplace_back(subset());
         insert(&subsets.back().members, subsets.back().members.end(), *small);
 
         for (const auto &e : *small) {
@@ -203,7 +203,7 @@ public:
 
         for (size_t i = seen.find_first(); i != seen.npos;
              i = seen.find_next(i)) {
-            containing->push_back(i);
+            containing->emplace_back(i);
         }
     }
 
@@ -240,7 +240,7 @@ public:
             assert(sub < subsets.size());
 
             member_to_subset[i] = sub;
-            subsets[sub].members.push_back(i);
+            subsets[sub].members.emplace_back(i);
         }
 
         /* none of the subsets should be empty */

src/util/report_manager.cpp

@@ -66,7 +66,7 @@ u32 ReportManager::getInternalId(const Report &ir) {
     }
 
     u32 size = reportIds.size();
-    reportIds.push_back(ir);
+    reportIds.emplace_back(ir);
     reportIdToInternalMap.emplace(ir, size);
     DEBUG_PRINTF("new report %u\n", size);
     return size;