github_mirrors/vectorscan
3
0
Fork 1
mirror of https://github.com/VectorCamp/vectorscan.git synced 2025-11-20 10:56:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix marked as false positive knownConditionTrueFalse cppcheck warnings

Browse Source 
std::make_shared<> does not return null, it throws std::bad_alloc.
This commit is contained in:
Konstantinos Margaritis
2024-05-12 18:40:51 +03:00
parent 103b70b8d0
commit 2b76edee4a
4 changed files with 3 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/nfagraph/ng_som.cpp
View File

@@ -2445,10 +2445,6 @@ static
bool doLitHaigSom(NG &ng, const NGHolder &g, som_type som) {
ue2_literal lit;
shared_ptr<NGHolder> rhs = make_shared<NGHolder>();
if (!rhs) {
assert(0);
throw std::bad_alloc();
}
if (!ng.cc.grey.allowLitHaig) {
return false;
}
@@ -2513,10 +2509,6 @@ bool doHaigLitHaigSom(NG &ng, NGHolder &g,
ue2_literal lit;
shared_ptr<NGHolder> rhs = make_shared<NGHolder>();
shared_ptr<NGHolder> lhs = make_shared<NGHolder>();
if (!rhs || !lhs) {
assert(0);
throw std::bad_alloc();
}
if (!splitOffBestLiteral(g, regions, &lit, &*lhs, &*rhs, ng.cc)) {
return false;