Fix false positive uselessAssignmentArg cppcheck warning

(also at the same time some cstyleCast warnings)
This commit is contained in:
Konstantinos Margaritis 2024-05-11 17:59:46 +03:00
parent cd1e13d4d2
commit 0f61853a37

View File

@ -111,21 +111,33 @@ void write_out(scatter_full_plan *plan_out, void *aux_out,
const scatter_plan_raw &raw, u32 aux_base_offset) { const scatter_plan_raw &raw, u32 aux_base_offset) {
memset(plan_out, 0, sizeof(*plan_out)); memset(plan_out, 0, sizeof(*plan_out));
#define DO_CASE(t) \ if (!raw.p_u64a.empty()) {
if (!raw.p_##t.empty()) { \ plan_out->s_u64a_offset = aux_base_offset;
plan_out->s_##t##_offset = aux_base_offset; \ plan_out->s_u64a_count = raw.p_u64a.size();
plan_out->s_##t##_count = raw.p_##t.size(); \ assert(ISALIGNED_N(static_cast<char *>(aux_out) + aux_base_offset, alignof(scatter_unit_u64a)));
assert(ISALIGNED_N((char *)aux_out + aux_base_offset, \ memcpy(static_cast<char *>(aux_out) + aux_base_offset, raw.p_u64a.data(), byte_length(raw.p_u32));
alignof(scatter_unit_##t))); \ aux_base_offset += byte_length(raw.p_u64a);
memcpy((char *)aux_out + aux_base_offset, raw.p_##t.data(), \ }
byte_length(raw.p_##t)); \ if (!raw.p_u32.empty()) {
aux_base_offset += byte_length(raw.p_##t); \ plan_out->s_u32_offset = aux_base_offset;
plan_out->s_u32_count = raw.p_u32.size();
assert(ISALIGNED_N(static_cast<char *>(aux_out) + aux_base_offset, alignof(scatter_unit_u32)));
memcpy(static_cast<char *>(aux_out) + aux_base_offset, raw.p_u32.data(), byte_length(raw.p_u32));
aux_base_offset += byte_length(raw.p_u32);
}
if (!raw.p_u16.empty()) {
plan_out->s_u16_offset = aux_base_offset;
plan_out->s_u16_count = raw.p_u16.size();
assert(ISALIGNED_N(static_cast<char *>(aux_out) + aux_base_offset, alignof(scatter_unit_u16)));
memcpy(static_cast<char *>(aux_out) + aux_base_offset, raw.p_u16.data(), byte_length(raw.p_u16));
aux_base_offset += byte_length(raw.p_u16);
}
if (!raw.p_u8.empty()) {
plan_out->s_u8_offset = aux_base_offset;
plan_out->s_u8_count = raw.p_u8.size();
assert(ISALIGNED_N(static_cast<char *>(aux_out) + aux_base_offset, alignof(scatter_unit_u8)));
memcpy(static_cast<char *>(aux_out) + aux_base_offset, raw.p_u8.data(), byte_length(raw.p_u8));
} }
DO_CASE(u64a);
DO_CASE(u32);
DO_CASE(u16);
DO_CASE(u8);
} }
} // namespace ue2 } // namespace ue2