From ec40433c5c60ca1d95d5cc9009187479c271a695 Mon Sep 17 00:00:00 2001 From: Faisal Salman Date: Sat, 15 Sep 2012 01:47:04 +0700 Subject: [PATCH] Fix node.js old example in readme --- readme.md | 15 ++++++--------- ua-parser.js | 6 +++--- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/readme.md b/readme.md index feb7777..53ccb77 100644 --- a/readme.md +++ b/readme.md @@ -70,16 +70,13 @@ Extract detailed type of web browser, layout engine, operating system, and devic ## Using node.js ```js -var UAParser = require('ua-parser'); -var parser = new UAParser(); -var ua1 = 'Mozilla/5.0 (PlayBook; U; RIM Tablet OS 1.0.0; en-US) AppleWebKit/534.11 (KHTML, like Gecko) Version/7.1.0.7 Safari/534.11'; -var ua2 = 'Midori/0.2 (X11; Linux; U; cs-cz) WebKit/531.2+'; +var UAParser = require('ua-parser'); +var parser = new UAParser(); +var uaString = 'Mozilla/5.0 (PlayBook; U; RIM Tablet OS 1.0.0; en-US) AppleWebKit/534.11 (KHTML, like Gecko) Version/7.1.0.7 Safari/534.11'; -console.log(parser.setUA(ua1).getDevice().name); // "PlayBook" -console.log(parser.getOS()) // {name: "RIM Tablet OS", version: "1.0.0"} -console.log(parser.getOS(ua2)) // {name: "Linux", version: undefined} -console.log(parser.getOS()) // {name: "RIM Tablet OS", version: "1.0.0"} -console.log(parser.getEngine().name); // "AppleWebKit" +console.log(parser.setUA(uaString).getDevice().name); // "PlayBook" +console.log(parser.getOS()) // {name: "RIM Tablet OS", version: "1.0.0"} +console.log(parser.getEngine().name); // "AppleWebKit" ``` ## License diff --git a/ua-parser.js b/ua-parser.js index c1e7360..0c8a980 100644 --- a/ua-parser.js +++ b/ua-parser.js @@ -19,7 +19,7 @@ // build object barebones for (k = 0; k < props.length; k++) { - if (typeof props[k] == 'object') { + if (typeof props[k] === 'object') { result[props[k][0]] = undefined; } else { result[props[k]] = undefined; @@ -51,8 +51,8 @@ var maps = { - check : function(str, map){ - for (var i in map){ + check : function (str, map) { + for (var i in map) { if (map.hasOwnProperty(i)) { if (typeof map[i] === 'object' && map[i].length > 0) { for (var j = 0; j < map[i].length; j++) {