From a19977ce4c99a03e7b89c6c8d5b579bd4c6370ce Mon Sep 17 00:00:00 2001 From: Faisal Salman Date: Mon, 21 Jul 2025 11:53:03 +0700 Subject: [PATCH] Fix #796: Improve device detection for Pico Neo 3 --- src/main/ua-parser.js | 2 +- test/data/ua/device/pico.json | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js index 7d8c28c..0d5eb3d 100755 --- a/src/main/ua-parser.js +++ b/src/main/ua-parser.js @@ -883,7 +883,7 @@ /droid.+; (glass) \d/i // Google Glass ], [MODEL, [VENDOR, GOOGLE], [TYPE, XR]], [ - /(pico) (4|neo3(?: link|pro)?)/i // Pico + /(pico) ([\w ]+) os\d/i // Pico ], [VENDOR, MODEL, [TYPE, XR]], [ /(quest( \d| pro)?s?).+vr/i // Meta Quest ], [MODEL, [VENDOR, FACEBOOK], [TYPE, XR]], [ diff --git a/test/data/ua/device/pico.json b/test/data/ua/device/pico.json index 2f28212..029a7c1 100644 --- a/test/data/ua/device/pico.json +++ b/test/data/ua/device/pico.json @@ -25,5 +25,23 @@ "model": "Neo3 Link", "type": "xr" } + }, + { + "desc": "Pico Neo 3", + "ua": "Mozilla/5.0 (X11; Linux x86_64; Pico Neo 3 OS5.12.2 like Quest) AppleWebKit/537.36 (KHTML, like Gecko) PicoBrowser/3.3.48 Chrome/105.0.5195.68 VR Safari/537.36 OculusBrowser/7.0", + "expect": { + "vendor": "Pico", + "model": "Neo 3", + "type": "xr" + } + }, + { + "desc": "Pico Neo 3 Pro", + "ua": "Mozilla/5.0 (X11; Linux x86_64; Pico Neo 3 Pro OS5.9.9.0 like Quest) AppleWebKit/537.36 (KHTML, like Gecko) PicoBrowser/3.3.46 Chrome/105.0.5195.68 VR Safari/537.36 OculusBrowser/7.0", + "expect": { + "vendor": "Pico", + "model": "Neo 3 Pro", + "type": "xr" + } } ] \ No newline at end of file