From 9f0419607baea6235f812553b8f9fca760f1e479 Mon Sep 17 00:00:00 2001 From: Faisal Salman Date: Fri, 11 Nov 2016 10:40:32 +0700 Subject: [PATCH] Fix #127 galaxy note --- src/ua-parser.js | 2 +- test/device-test.json | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/ua-parser.js b/src/ua-parser.js index d0c988e..f782918 100644 --- a/src/ua-parser.js +++ b/src/ua-parser.js @@ -583,7 +583,7 @@ /\(dtv[\);].+(aquos)/i // Sharp ], [MODEL, [VENDOR, 'Sharp'], [TYPE, SMARTTV]], [ - /android.+((sch-i[89]0\d|shw-m380s|gt-p\d{4}|gt-n8000|sgh-t8[56]9|nexus 10))/i, + /android.+((sch-i[89]0\d|shw-m380s|gt-p\d{4}|gt-n\d+|sgh-t8[56]9|nexus 10))/i, /((SM-T\w+))/i ], [[VENDOR, 'Samsung'], MODEL, [TYPE, TABLET]], [ // Samsung /smart-tv.+(samsung)/i diff --git a/test/device-test.json b/test/device-test.json index 7967494..2a0c75e 100644 --- a/test/device-test.json +++ b/test/device-test.json @@ -199,6 +199,16 @@ "type" : "tablet" } }, + { + "desc" : "Samsung Galaxy Note 8", + "ua" : "Mozilla/5.0 (Linux; Android 4.2.2; GT-N5100 Build/JDQ39) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.141 Safari/537.36", + "expect" : + { + "vendor" : "Samsung", + "model" : "GT-N5100", + "type" : "tablet" + } + }, { "desc" : "Samsung SM-T231", "ua" : "Mozilla/5.0 (Linux; Android 4.4.2; SM-T231 Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.135 Safari/537.36",