From 7da36bad0b082efd6d3b2517df8a2ee3e1998544 Mon Sep 17 00:00:00 2001 From: Davit Barbakadze Date: Fri, 23 May 2014 21:12:26 +0400 Subject: [PATCH] Make sure that we check for all requested properties. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only ‘version’ was checked, because of plain for loop. Switch to forEach() and closure. --- test/test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test.js b/test/test.js index 978f4f0..9408f0e 100644 --- a/test/test.js +++ b/test/test.js @@ -50,13 +50,13 @@ for (var i in methods) { describe('[' + methods[i]['list'][j].desc + ']', function () { describe('"' + methods[i]['list'][j].ua + '"', function () { var expect = methods[i]['list'][j].expect; - var result = parser.setUA(methods[i]['list'][j].ua).getResult()[methods[i]['label']]; - for (var k in methods[i]['properties']) { - var m = methods[i]['properties'][k]; + var result = parser.setUA(methods[i]['list'][j].ua).getResult()[methods[i]['label']]; + + methods[i]['properties'].forEach(function(m) { it('should return ' + methods[i]['label'] + ' ' + m + ': ' + expect[m], function () { assert.equal(result[m], expect[m] != 'undefined' ? expect[m] : undefined); }); - } + }); }); }); }