From 4ca311224fa3128f92e8be5ee79a6fb98e1c3d3e Mon Sep 17 00:00:00 2001 From: nionata Date: Wed, 3 Jun 2020 18:10:56 -0400 Subject: [PATCH] catch facebook in-app browsers that do not contain versions --- src/ua-parser.js | 5 ++++- test/browser-test.json | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/ua-parser.js b/src/ua-parser.js index d89312c..516afe0 100755 --- a/src/ua-parser.js +++ b/src/ua-parser.js @@ -315,8 +315,11 @@ /xiaomi\/miuibrowser\/([\w\.]+)/i // MIUI Browser ], [VERSION, [NAME, 'MIUI Browser']], [ - /;fbav\/([\w\.]+);/i // Facebook App for iOS & Android + /;fbav\/([\w\.]+);/i // Facebook App for iOS & Android with version ], [VERSION, [NAME, 'Facebook']], [ + + /FBAN\/FBIOS|FB_IAB\/FB4A/i // Facebook App for iOS & Android without version + ], [[NAME, 'Facebook']], [ /safari\s(line)\/([\w\.]+)/i, // Line App for iOS /android.+(line)\/([\w\.]+)\/iab/i // Line App for Android diff --git a/test/browser-test.json b/test/browser-test.json index 9544a47..fb0c5be 100644 --- a/test/browser-test.json +++ b/test/browser-test.json @@ -310,7 +310,7 @@ } }, { - "desc" : "Facebook in-App Browser for Android", + "desc" : "Facebook in-App Browser for Android with version", "ua" : "Mozilla/5.0 (Linux; Android 5.0; SM-G900P Build/LRX21T; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/43.0.2357.121 Mobile Safari/537.36 [FB_IAB/FB4A;FBAV/35.0.0.48.273;]", "expect" : { @@ -320,7 +320,7 @@ } }, { - "desc" : "Facebook in-App Browser for iOS", + "desc" : "Facebook in-App Browser for iOS with version", "ua" : "Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_1 like Mac OS X) AppleWebKit/603.1.30 (KHTML, like Gecko) Mobile/14E304 [FBAN/FBIOS;FBAV/91.0.0.41.73;FBBV/57050710;FBDV/iPhone8,1;FBMD/iPhone;FBSN/iOS;FBSV/10.3.1;FBSS/2;FBCR/Telekom.de;FBID/phone;FBLC/de_DE;FBOP/5;FBRV/0])", "expect" : { @@ -329,6 +329,16 @@ "major" : "91" } }, + { + "desc" : "Facebook in-App Browser for iOS without version", + "ua" : "Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 [FBAN/FBIOS;FBDV/iPhone10,2;FBMD/iPhone;FBSN/iOS;FBSV/13.3.1;FBSS/3;FBID/phone;FBLC/en_US;FBOP/5;FBCR/]", + "expect" : + { + "name" : "Facebook", + "version" : "undefined", + "major" : "undefined" + } + }, { "desc" : "Falkon", "ua" : "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Falkon/3.0.0 Chrome/61.0.3163.140 Safari/537.36",