From b00b2a7bcf19e7d0f189ec4467cee3781c2e4cae Mon Sep 17 00:00:00 2001 From: Admas Date: Fri, 17 Apr 2015 09:21:11 -0700 Subject: [PATCH 1/2] Adding WIndows 10 IE test --- test/browser-test.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/browser-test.json b/test/browser-test.json index 56fae07..54462c1 100644 --- a/test/browser-test.json +++ b/test/browser-test.json @@ -688,5 +688,15 @@ "version" : "1.0.1084.5402", "major" : "1" } + }, + { + "desc" : "Windows 10 EI", + "ua" : "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0", + "expect" : + { + "name" : "IE", + "version" : "12.0", + "major" : "12" + } } ] From c7749b3a2a638fa32a0e9eda4948121ffe1b277d Mon Sep 17 00:00:00 2001 From: Admas Date: Fri, 17 Apr 2015 09:23:28 -0700 Subject: [PATCH 2/2] Adding WIndows 10 IE regex IE 12 for windows 10 uses gets caught as chrome: https://msdn.microsoft.com/en-us/library/ie/hh869301%28v=vs.85%29.aspx Now we search for Edge and mark it as IE --- src/ua-parser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ua-parser.js b/src/ua-parser.js index 32bbddc..6516db0 100644 --- a/src/ua-parser.js +++ b/src/ua-parser.js @@ -254,6 +254,7 @@ ], [NAME, VERSION], [ /(trident).+rv[:\s]([\w\.]+).+like\sgecko/i // IE11 + /(Edge)\/((\d+)?[\w\.]+)/i // IE12 ], [[NAME, 'IE'], VERSION], [ /(yabrowser)\/([\w\.]+)/i // Yandex