From 46615e70db3bd098dd471f75b7b91afa96e819a7 Mon Sep 17 00:00:00 2001 From: Faisal Salman Date: Fri, 12 Mar 2021 19:20:17 +0700 Subject: [PATCH] Fix #454 Improve Samsung detection --- src/ua-parser.js | 2 +- test/device-test.json | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/ua-parser.js b/src/ua-parser.js index 9424501..b2ac7f1 100755 --- a/src/ua-parser.js +++ b/src/ua-parser.js @@ -540,7 +540,7 @@ /smart-tv.+(samsung)/i ], [VENDOR, [TYPE, SMARTTV], MODEL], [ /((s[cgp]h-\w+|gt-\w+|galaxy\snexus|sm-\w[\w\d]+))/i, - /(sam[sung]*)[\s-]*(\w+-?[\w-]*)/i, + /\s(sam)(?:sung)[\s-]([\w-]+)/i, /sec-((sgh\w+))/i ], [[VENDOR, 'Samsung'], MODEL, [TYPE, MOBILE]], [ diff --git a/test/device-test.json b/test/device-test.json index a0e33c6..29fb151 100644 --- a/test/device-test.json +++ b/test/device-test.json @@ -1378,5 +1378,14 @@ "expect": { "type": "mobile" } + }, + { + "desc": "Issue #454", + "ua": "Mosamzilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20050603 Netscape/8.0.2", + "expect": { + "vendor": "undefined", + "model": "undefined", + "type": "undefined" + } } ]