github_mirrors/quickjs
3
0
Fork 1
mirror of https://github.com/bellard/quickjs.git synced 2025-11-15 18:22:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling in Promise.withResolvers (bnoordhuis)

Browse Source
This commit is contained in:
Fabrice Bellard
2025-10-03 12:00:26 +02:00
parent 31663a930d
commit f1253f2ab5
1 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
quickjs.c
View File

@@ -51667,17 +51667,30 @@ static JSValue js_promise_withResolvers(JSContext *ctx,
if (JS_IsException(result_promise)) if (JS_IsException(result_promise))
return result_promise; return result_promise;
obj = JS_NewObject(ctx); obj = JS_NewObject(ctx);
if (JS_IsException(obj)) { if (JS_IsException(obj))
goto exception;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_promise, result_promise,
JS_PROP_C_W_E) < 0) {
goto exception;
}
result_promise = JS_UNDEFINED;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_resolve, resolving_funcs[0],
JS_PROP_C_W_E) < 0) {
goto exception;
}
resolving_funcs[0] = JS_UNDEFINED;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_reject, resolving_funcs[1],
JS_PROP_C_W_E) < 0) {
goto exception;
}
return obj;
exception:
JS_FreeValue(ctx, resolving_funcs[0]); JS_FreeValue(ctx, resolving_funcs[0]);
JS_FreeValue(ctx, resolving_funcs[1]); JS_FreeValue(ctx, resolving_funcs[1]);
JS_FreeValue(ctx, result_promise); JS_FreeValue(ctx, result_promise);
JS_FreeValue(ctx, obj);
return JS_EXCEPTION; return JS_EXCEPTION;
} }
JS_DefinePropertyValue(ctx, obj, JS_ATOM_promise, result_promise, JS_PROP_C_W_E);
JS_DefinePropertyValue(ctx, obj, JS_ATOM_resolve, resolving_funcs[0], JS_PROP_C_W_E);
JS_DefinePropertyValue(ctx, obj, JS_ATOM_reject, resolving_funcs[1], JS_PROP_C_W_E);
return obj;
}
static JSValue js_promise_try(JSContext *ctx, JSValueConst this_val, static JSValue js_promise_try(JSContext *ctx, JSValueConst this_val,
int argc, JSValueConst *argv) int argc, JSValueConst *argv)