mirror of
https://github.com/owasp-modsecurity/ModSecurity.git
synced 2025-08-13 21:36:00 +03:00
47be22e62a
AnchoredSetVariable::resolve is called for every rule (see RuleWithOperator::evaluate). The previous implementation allocated a new copy of every variable, which quickly added up. In my tests, AnchoredSetVariable::resolve function consumed 7.8% of run time. AnchoredSetVariable (which is a multimap) values are never changed, only added. This means it's safe to store them in std::shared_ptr, and make resolve return shared_ptr pointing to the same object. Other resolve implementation could also use this optimization by not allocating new objects, however, they are not hot spots, so this optimization was not implemented there. In my benchmark, this raises performance from 117 requests per second to 131 RPS, and overhead is lowered from 7.8% to 2.4%. As a bonus, replacing plain pointer with smart pointers make code cleaner, since using smart pointers makes manual deletes no longer necessary. Additionally, VariableOrigin is now stored in plain std::vector, since it's wasteful to store structure containing just two integer values using std::list<std::unique_ptr<T>>.
133 lines
3.1 KiB
C++
133 lines
3.1 KiB
C++
/*
|
|
* ModSecurity, http://www.modsecurity.org/
|
|
* Copyright (c) 2015 - 2020 Trustwave Holdings, Inc. (http://www.trustwave.com/)
|
|
*
|
|
* You may not use this file except in compliance with
|
|
* the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* If any of the files related to licensing are missing or if you have any
|
|
* other questions related to licensing please contact Trustwave Holdings, Inc.
|
|
* directly using the email address security@modsecurity.org.
|
|
*
|
|
*/
|
|
|
|
|
|
#ifdef __cplusplus
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <memory>
|
|
#include <list>
|
|
#include <utility>
|
|
#endif
|
|
|
|
#include "modsecurity/variable_origin.h"
|
|
|
|
#ifndef HEADERS_MODSECURITY_VARIABLE_VALUE_H_
|
|
#define HEADERS_MODSECURITY_VARIABLE_VALUE_H_
|
|
|
|
#ifndef __cplusplus
|
|
typedef struct Variable_t VariableValue;
|
|
#endif
|
|
|
|
#ifdef __cplusplus
|
|
namespace modsecurity {
|
|
|
|
class Collection;
|
|
class VariableValue {
|
|
public:
|
|
using Origins = std::vector<VariableOrigin>;
|
|
|
|
explicit VariableValue(const std::string *key,
|
|
const std::string *value = nullptr)
|
|
: m_collection(""),
|
|
m_key(*key),
|
|
m_keyWithCollection(*key),
|
|
m_value(value != nullptr?*value:"")
|
|
{ }
|
|
|
|
VariableValue(const std::string *collection,
|
|
const std::string *key,
|
|
const std::string *value)
|
|
: m_collection(*collection),
|
|
m_key(*key),
|
|
m_keyWithCollection(*collection + ":" + *key),
|
|
m_value(*value)
|
|
{ }
|
|
|
|
explicit VariableValue(const VariableValue *o) :
|
|
m_collection(o->m_collection),
|
|
m_key(o->m_key),
|
|
m_keyWithCollection(o->m_keyWithCollection),
|
|
m_value(o->m_value)
|
|
{
|
|
for (auto &i : o->m_orign) {
|
|
VariableOrigin *origin(new VariableOrigin());
|
|
origin->m_offset = i.m_offset;
|
|
origin->m_length = i.m_length;
|
|
m_orign.push_back(*origin);
|
|
}
|
|
}
|
|
|
|
VariableValue(const VariableValue &o) :
|
|
m_collection(o.m_collection),
|
|
m_key(o.m_key),
|
|
m_keyWithCollection(o.m_keyWithCollection),
|
|
m_value(o.m_value)
|
|
{
|
|
for (auto &i : o.m_orign) {
|
|
VariableOrigin *origin(new VariableOrigin());
|
|
origin->m_offset = i.m_offset;
|
|
origin->m_length = i.m_length;
|
|
m_orign.push_back(*origin);
|
|
}
|
|
}
|
|
|
|
const std::string& getKey() const {
|
|
return m_key;
|
|
}
|
|
|
|
|
|
const std::string& getKeyWithCollection() const {
|
|
return m_keyWithCollection;
|
|
}
|
|
|
|
|
|
const std::string& getCollection() const {
|
|
return m_collection;
|
|
}
|
|
|
|
|
|
const std::string& getValue() const {
|
|
return m_value;
|
|
}
|
|
|
|
|
|
void setValue(const std::string &value) {
|
|
m_value = value;
|
|
}
|
|
|
|
|
|
void addOrigin(VariableOrigin origin) {
|
|
m_orign.push_back(std::move(origin));
|
|
}
|
|
|
|
|
|
const Origins& getOrigin() const {
|
|
return m_orign;
|
|
}
|
|
|
|
private:
|
|
Origins m_orign;
|
|
std::string m_collection;
|
|
std::string m_key;
|
|
std::string m_keyWithCollection;
|
|
std::string m_value;
|
|
};
|
|
|
|
} // namespace modsecurity
|
|
#endif
|
|
|
|
#endif // HEADERS_MODSECURITY_VARIABLE_VALUE_H_
|