Commit Graph

Select branches

Hide Pull Requests

gh-pages

nginx_refactoring

nginx_refactoring_def

v2/dev/fix-pcre-study-leak-610

v2/dev/itk-ruid-test

v2/dev/memcache_collections

v2/dev/sechash_test_case

v2/dev/v2.9.4

v2/exp/ModSecurity_for_Java

v2/exp/collection_garbage_freq

v2/exp/json_sanitizer

v2/exp/python_support

v2/master

v2/per/without_libxml_dependency

v3/dev/3.1

v3/dev/3.1-experimental

v3/dev/3.1-experimental-2374

v3/dev/3.1-experimental-II

v3/dev/3.1-experimental-III

v3/dev/3.1-experimental-test

v3/dev/experimental_yara

v3/dev/fix_using

v3/dev/github-actions-test

v3/dev/hyperscan

v3/dev/issue_215

v3/dev/issue_340

v3/dev/master

v3/dev/master-fix

v3/dev/master-no-warnings

v3/dev/master-on-workflow

v3/dev/master-on-workflow-n-travis

v3/dev/parser_trail

v3/dev/phases

v3/dev/pkg-config

v3/dev/pull_2387

v3/dev/pull_2427

v3/dev/pull_2430

v3/dev/pull_2520

v3/dev/re2

v3/dev/reload

v3/dev/reload2

v3/dev/sec_binary_rules

v3/dev/setenv

v3/dev/testing

v3/dev/wasm-experimental

v3/master

v3/twaf/3.0.2+315f98b

v3/twaf/v3.0.2

v3/twaf8.5

v3/twaf8.5-3.0.0-rc1

v3/twaf8.5-almost-gold

v3/twaf8.5-v3.0.0

v3/twaf8.5-v3.0.0-no-dynamic-rx

v3/twaf8.5-v3.0.0-perf

v3/twaf8.5-v3.0.0-perf-test

#1

#1

#10

#10

#100

#100

#101

#101

#102

#102

#103

#103

#1031

#1031

#1038

#104

#104

#1040

#1040

#1041

#1041

#1051

#1051

#1052

#1052

#106

#106

#1060

#1060

#107

#107

#1071

#1071

#108

#108

#1087

#1087

#109

#109

#1098

#1098

#11

#11

#110

#110

#1108

#1108

#111

#111

#1110

#1110

#1115

#1115

#112

#112

#1123

#1123

#113

#113

#1143

#1143

#1150

#1150

#1151

#1151

#1158

#1158

#116

#116

#1163

#1163

#1164

#1164

#1171

#1171

#1175

#1175

#1178

#1178

#1179

#1179

#118

#118

#1180

#1180

#1181

#1181

#1186

#1186

#1187

#1187

#119

#1190

#1190

#12

#12

#1200

#1200

#1204

#1204

#121

#121

#1213

#1213

#1216

#1216

#122

#122

#1220

#1220

#1223

#1223

#1224

#1224

#1225

#1225

#1231

#1233

#1233

#124

#124

#1249

#1249

#125

#125

#1256

#1256

#1257

#1257

#1258

#1258

#1259

#126

#126

#1261

#1261

#1263

#1263

#1266

#1266

#127

#127

#1270

#1270

#1271

#1271

#1274

#1274

#1279

#1279

#128

#128

#1281

#1281

#1282

#1282

#1283

#1283

#1289

#1289

#1298

#1298

#13

#13

#130

#130

#1301

#1301

#1306

#1306

#1308

#1308

#131

#131

#1324

#133

#133

#1332

#1332

#1339

#1339

#1340

#1340

#1343

#1343

#135

#135

#136

#136

#1371

#1371

#1373

#1373

#1374

#1374

#1379

#1379

#138

#138

#1380

#1380

#1381

#1381

#1382

#1382

#1383

#1383

#1384

#1384

#1385

#1385

#139

#139

#1393

#1393

#1400

#1400

#1401

#1401

#1402

#1402

#1403

#1403

#1404

#1404

#141

#141

#1410

#1410

#1413

#1413

#1414

#1414

#1415

#1415

#1429

#1429

#1433

#1433

#1436

#1436

#1439

#1439

#144

#144

#1446

#1446

#1454

#1454

#146

#146

#1467

#1467

#147

#147

#1473

#1473

#1479

#1479

#148

#148

#1485

#1485

#1486

#1486

#1487

#1487

#1488

#1488

#149

#149

#15

#15

#150

#150

#1500

#1500

#1501

#1501

#1502

#1502

#1510

#1510

#1511

#1511

#1513

#1513

#1514

#1514

#1515

#1515

#152

#152

#1523

#1523

#1524

#1524

#1525

#1525

#1526

#1527

#1527

#1530

#1530

#1536

#1536

#1538

#1538

#1539

#1540

#1540

#1541

#1541

#1543

#1545

#1545

#1571

#1571

#1572

#1572

#1577

#1583

#1598

#1598

#16

#16

#1609

#1611

#1612

#1613

#1613

#1614

#1614

#1615

#1615

#1619

#1619

#1621

#1621

#1623

#1623

#1624

#1624

#1636

#1636

#1639

#1640

#1640

#1651

#1651

#1652

#1652

#1667

#1667

#1675

#1675

#1677

#1677

#1678

#1678

#1683

#1690

#1690

#1691

#1691

#1694

#1694

#1696

#1696

#17

#17

#1701

#1701

#1702

#1702

#1713

#1713

#1714

#1715

#1715

#1716

#1716

#1721

#1721

#1730

#1730

#1735

#1735

#1737

#1737

#1738

#1738

#1739

#1739

#1740

#1740

#1744

#1744

#1747

#1747

#1748

#1748

#1749

#1749

#1750

#1750

#1751

#1751

#1752

#1752

#1755

#1755

#1756

#1756

#1757

#1757

#1758

#1758

#1759

#1759

#1760

#1760

#1761

#1761

#1765

#1765

#1769

#1769

#1771

#1771

#1775

#1775

#1781

#1781

#1783

#1783

#1786

#1786

#1787

#1787

#1788

#1788

#1790

#1790

#1792

#1792

#18

#18

#1801

#1801

#1806

#1806

#1807

#1807

#1810

#1810

#1814

#1814

#1820

#1820

#1821

#1822

#1823

#1823

#1826

#1826

#1847

#1847

#1852

#1852

#1854

#1854

#1855

#1855

#1856

#1856

#1859

#1859

#1861

#1861

#1881

#1881

#1886

#1886

#1890

#1891

#1895

#1895

#1897

#1897

#1901

#1901

#1910

#1910

#1912

#1917

#1919

#1920

#1922

#1922

#1924

#1943

#1949

#1955

#1957

#1959

#1966

#1973

#1978

#1984

#1990

#1992

#1997

#2

#2

#2002

#2003

#2007

#2011

#2012

#2012

#2014

#2015

#2016

#2017

#2018

#2023

#2024

#2031

#2032

#2045

#2045

#2046

#2048

#2049

#2057

#2058

#2059

#2060

#2063

#2068

#2071

#2073

#2092

#2094

#2094

#2095

#2097

#21

#21

#2102

#2103

#2107

#2113

#2114

#2119

#2119

#2123

#2130

#2134

#2134

#2155

#2171

#2177

#2177

#2179

#2189

#2190

#2191

#2193

#2197

#2199

#22

#22

#2201

#2202

#2203

#2205

#2214

#2219

#2225

#2229

#2234

#2235

#2236

#2239

#2253

#2261

#2263

#2265

#2295

#2297

#2304

#2304

#2315

#2316

#2317

#2321

#2322

#2342

#2348

#2353

#2353

#2363

#2368

#2369

#2370

#2374

#2375

#2378

#2379

#2387

#2393

#2394

#2396

#2399

#24

#24

#2412

#2417

#2417

#2424

#2430

#2433

#2435

#2436

#2440

#2441

#2443

#2444

#2445

#2446

#2449

#2451

#2453

#2455

#2461

#2467

#2471

#2473

#2474

#2478

#2479

#2485

#2492

#2497

#2499

#2505

#2518

#2518

#2520

#2520

#2522

#2535

#2542

#2551

#2551

#2562

#2570

#2574

#2578

#2580

#2586

#2588

#2591

#2592

#2593

#2596

#26

#26

#2600

#2602

#2604

#2607

#2612

#2616

#2619

#2620

#2620

#2621

#2622

#2633

#2634

#2635

#2638

#2642

#2643

#2644

#2656

#2657

#2660

#2661

#2663

#2667

#2673

#2677

#2680

#2681

#2681

#2685

#2686

#2688

#27

#27

#2707

#2708

#2708

#2714

#2715

#2718

#2718

#2719

#2721

#2721

#2723

#2725

#2727

#2728

#2731

#2732

#2735

#2736

#2738

#2748

#2748

#2749

#2751

#2753

#2757

#2758

#2760

#2761

#2762

#2763

#2770

#2775

#2776

#2780

#2781

#2783

#2783

#2785

#2786

#2786

#2788

#2789

#2791

#2792

#2794

#2795

#2796

#2797

#2799

#2800

#2801

#2806

#2812

#2813

#2818

#2823

#2823

#2827

#2828

#2831

#2832

#2833

#2834

#2839

#2840

#2844

#2846

#2850

#2850

#2854

#2857

#2862

#2864

#2866

#2868

#2870

#2876

#2883

#2886

#2890

#2891

#2892

#2894

#2898

#29

#2901

#2906

#2909

#2912

#2915

#2916

#2924

#2930

#2930

#2931

#2934

#2935

#2939

#2940

#2941

#2944

#2945

#2946

#2947

#2948

#2949

#2950

#2951

#2952

#2953

#2954

#2955

#2956

#2957

#2958

#2959

#2960

#2961

#2962

#2963

#2964

#2965

#2967

#2968

#2969

#2971

#2971

#2975

#2977

#2980

#2983

#2985

#2987

#2992

#2993

#2994

#2996

#2997

#2999

#3

#3

#30

#30

#3001

#3003

#3004

#3005

#3008

#3009

#3011

#3012

#3014

#3016

#3019

#3020

#3024

#3025

#3027

#3032

#3040

#3041

#3042

#3043

#3048

#3050

#3051

#3052

#3055

#3056

#3057

#3058

#3059

#3060

#3061

#3062

#3063

#3064

#3065

#3066

#3067

#3068

#3069

#3070

#3071

#3072

#3073

#3074

#3075

#3076

#3078

#3079

#3080

#3086

#3087

#3090

#3092

#3093

#3093

#3094

#3095

#3096

#3097

#3098

#3099

#31

#31

#3101

#3104

#3114

#3116

#3117

#3120

#3121

#3121

#3127

#3128

#3132

#3134

#3139

#3141

#3144

#3145

#3146

#3148

#3149

#3150

#3150

#3151

#3152

#3152

#3153

#3154

#3155

#3156

#3156

#3157

#3157

#3158

#3159

#3160

#3161

#3164

#3166

#3166

#3171

#3172

#3172

#3176

#3176

#3181

#3181

#3182

#3185

#3187

#3188

#3189

#3190

#3191

#3192

#3193

#3194

#3198

#3199

#3202

#3203

#3205

#3206

#3207

#3208

#3209

#3210

#3211

#3212

#3213

#3214

#3216

#3217

#3218

#3219

#3220

#3221

#3222

#3223

#3223

#3224

#3225

#3226

#3227

#3228

#3229

#3231

#3232

#3233

#3236

#3236

#3239

#3239

#3240

#3241

#3243

#3245

#3247

#3248

#3250

#3253

#3254

#3257

#3262

#3264

#3265

#3266

#3267

#3268

#3269

#3270

#3279

#3280

#3283

#3284

#3285

#3287

#3291

#3298

#33

#33

#3306

#3307

#3314

#3319

#3321

#3322

#3335

#3339

#3342

#3345

#3350

#3354

#3358

#3359

#3359

#3361

#3363

#3364

#3365

#3371

#3372

#3374

#3375

#3376

#3377

#3378

#3379

#3383

#3385

#3386

#3387

#3388

#3389

#3390

#3391

#3392

#3393

#3398

#34

#34

#3400

#3401

#3405

#3406

#3406

#3411

#3412

#3418

#3419

#3420

#3421

#3422

#3424

#3425

#3426

#3427

#3428

#3430

#3432

#3434

#3437

#3438

#3442

#3443

#3447

#3452

#3454

#3455

#3456

#3456

#3458

#3464

#35

#35

#36

#36

#37

#37

#38

#38

#39

#39

#4

#42

#43

#43

#44

#44

#45

#45

#46

#48

#48

#49

#49

#5

#5

#50

#50

#51

#51

#52

#52

#53

#53

#54

#54

#55

#55

#57

#57

#578

#579

#58

#58

#583

#583

#59

#59

#591

#591

#592

#592

#594

#594

#595

#595

#596

#596

#597

#597

#6

#6

#604

#604

#606

#606

#607

#607

#608

#608

#609

#609

#61

#61

#612

#612

#614

#614

#617

#617

#618

#618

#619

#619

#62

#62

#620

#620

#622

#622

#64

#64

#65

#65

#659

#66

#66

#666

#668

#668

#669

#67

#67

#672

#672

#68

#68

#692

#697

#697

#698

#698

#7

#7

#70

#70

#700

#700

#701

#701

#709

#709

#71

#71

#718

#718

#72

#72

#720

#720

#721

#721

#722

#722

#723

#723

#73

#73

#74

#74

#740

#740

#745

#745

#749

#749

#75

#757

#76

#76

#767

#767

#77

#77

#775

#775

#776

#78

#78

#782

#782

#79

#79

#794

#796

#796

#8

#8

#80

#80

#81

#81

#810

#810

#815

#815

#817

#817

#82

#82

#824

#824

#826

#826

#83

#83

#836

#836

#837

#837

#84

#84

#840

#840

#842

#842

#844

#844

#85

#85

#852

#852

#86

#86

#87

#87

#872

#872

#879

#879

#88

#88

#881

#881

#883

#883

#9

#9

#904

#904

#906

#906

#91

#91

#914

#914

#92

#92

#927

#927

#93

#93

#933

#933

#94

#94

#95

#95

#950

#950

#96

#96

#961

#97

#97

#978

#978

#98

#98

#980

#980

#982

#982

#99

#99

#996

#996

v2.1.0

v2.1.0-rc7

v2.1.1

v2.1.1-dev2

v2.1.1-dev3

v2.1.1-dev4

v2.1.1-rc1

v2.1.1-rc2

v2.1.2

v2.1.2-rc1

v2.1.2-rc2

v2.1.2-rc3

v2.1.3

v2.1.3-rc1

v2.1.3-rc2

v2.1.4

v2.1.4-rc1

v2.1.4-rc2

v2.1.4-rc3

v2.1.4-rc4

v2.1.5

v2.1.5-rc1

v2.1.6

v2.1.6-rc1

v2.1.7

v2.2.0-dev1

v2.5.0

v2.5.0-dev2

v2.5.0-rc1

v2.5.0-rc2

v2.5.0-rc3

v2.5.0-rc3-pre2

v2.5.0-rc4

v2.5.1

v2.5.1-rc1

v2.5.10

v2.5.10-dev1

v2.5.10-dev2

v2.5.10-dev3

v2.5.11

v2.5.12

v2.5.13

v2.5.2

v2.5.3

v2.5.4

v2.5.5

v2.5.6

v2.5.7

v2.5.7-rc1

v2.5.8

v2.5.9

v2.6.0

v2.6.0-rc1

v2.6.0-rc2

v2.6.1

v2.6.2

v2.6.2-rc1

v2.6.3

v2.6.3-rc1

v2.6.4

v2.6.4-rc1

v2.6.5

v2.6.6

v2.6.7

v2.6.8

v2.7.0

v2.7.0-rc1

v2.7.0-rc3

v2.7.1

v2.7.2

v2.7.3

v2.7.4

v2.7.5

v2.7.6

v2.7.7

v2.8.0

v2.8.0-rc1

v2.9.0

v2.9.0-rc1

v2.9.0-rc2

v2.9.1

v2.9.1-rc1

v2.9.10

v2.9.11

v2.9.12

v2.9.2

v2.9.3

v2.9.4

v2.9.5

v2.9.6

v2.9.7

v2.9.8

v2.9.9

v3.0.0

v3.0.0-rc1

v3.0.1

v3.0.10

v3.0.11

v3.0.12

v3.0.13

v3.0.14

v3.0.2

v3.0.3

v3.0.4

v3.0.5

v3.0.6

v3.0.7

v3.0.8

v3.0.9

Mono Color

• c0681b6239 Update README.md Elevations 2024-12-11 19:29:32 +13:00
• 7b4c3a2c0f Update Dockerfile Elevations 2024-12-11 19:06:59 +13:00
• 17700eca5b Update README.md Elevations 2024-12-11 17:45:37 +13:00
• a07d0c7d34 Fix missing libpcre2 dependency on macOS GitHub runner Gabor Berkes 2024-12-10 21:40:09 +00:00
• 106ed22b6d Fix typo in pcre.m4: corrected PCRE_CFLAGS assignment Gabor Berkes 2024-12-10 10:58:20 +00:00
• c6433df7b2 Refactor build system to use libpcre2 as the default Gabor Berkes 2024-12-10 10:16:14 +00:00
• 4fb22466a0 Cleanup: Remove useless/nonfunctional AM_CONDITIONAL macros Gabor Berkes 2024-12-10 07:32:13 +00:00
• d9101a4fe1 Merge pull request #3306 from airween/v3/time_mon_fix Ervin Hegedus 2024-11-24 16:28:47 +00:00
• daf550ef5f Fix regex for test Ervin Hegedus 2024-11-24 14:06:50 +01:00
• db7e4cb67b Align TIME_MON variable's behavior Ervin Hegedus 2024-11-22 10:40:50 +01:00
• fd4564131f Merge pull request #3307 from gberkes/v3/cppcheck_v2_16_upgrade Ervin Hegedus 2024-11-23 09:28:08 +00:00
• 530919439b Fix: Add false positive cppcheck-suppress for compatibility with updated cppcheck version Gabor Berkes 2024-11-22 23:36:40 +00:00
• 41fd21b0fb Merge pull request #3298 from airween/v3/sethostnamefix Ervin Hegedus 2024-11-19 20:49:00 +00:00
• fa621f81e9 Merge pull request #3284 from marcstern/v2/pr/utf8toUnicodeVsMultibyte Marc Stern 2024-11-12 17:34:05 +01:00
• d422b36966 Add condition before set hostname; move setRequestHostName() before processConnection() Ervin Hegedus 2024-11-12 16:55:02 +01:00
• 4a720004dd Merge pull request #3287 from hnakamur/fix_modsecurity-regression-test-secremoterules.txt_url_in_example Ervin Hegedus 2024-11-06 10:20:58 +00:00
• 42a401892b Fix modsecurity-regression-test-secremoterules.txt URL in example Hiroaki Nakamura 2024-10-24 11:52:59 +09:00
• 5bec188146 Merge pull request #3291 from hnakamur/add_test_regression_rules Ervin Hegedus 2024-11-05 11:03:04 +00:00
• 87dbae9bb2 assert(input != NULL); Marc Stern 2024-11-04 13:53:28 +01:00
• 742f97ccc0 Add regression rules for test Hiroaki Nakamura 2024-11-01 17:53:24 +09:00
• 907d61ad6d Incorrect utf8toUnicode transformation for 00xx Fix issue and restructure handling Marc Stern 2024-10-22 15:51:55 +02:00
• 29a86b17df Merge pull request #3283 from eduar-hte/cppcheck2142 Ervin Hegedus 2024-10-22 13:54:52 +02:00
• aca93f568e Remove no longer needed cppcheck inline suppressions. Eduardo Arias 2024-10-21 16:04:14 -03:00
• 7ec50eb53f Make GeoLookup::debug function static (and non-member), as suggested by cppcheck. Eduardo Arias 2024-10-21 16:02:27 -03:00
• 4e68edf0e5 Replace usage of sscanf with strtol to remove cppcheck inline suppression Eduardo Arias 2024-10-21 15:52:14 -03:00
• cdaf32f521 Remove cppcheck suppression by replacing use of local variable to alias this->m_variables - The name of the local variable would clash with the namespace of the same name, which may have lead cppcheck to think the variable was not used. Eduardo Arias 2024-10-21 15:30:23 -03:00
• ce9a3167fa Use initialization list to initialize m_service - This is correct because base class is initialized before members are initialized. - Removes cppcheck suppression by addressing reported issue. - Leverage C++11's 'default member initializer' to initialize m_provider & m_demandsPassword and address Sonarcloud issue. Eduardo Arias 2024-10-21 15:28:21 -03:00
• b0497d9cb9 Avoid this unnecessary copy by using a "const" reference. - Reported by Sonarcloud Eduardo Arias 2024-10-19 13:13:38 -03:00
• d1e7e7b4f2 Refactor to remove duplicate code in ValidateSchema & ValidateDTD - Reported by Sonarcloud Eduardo Arias 2024-10-19 12:45:50 -03:00
• 2fb446ab2d Address cppcheck warnings generated after addressing Sonarcloud suggestions - The following two warnings were generated after introducing the change to instantiate the DigestImpl template with the address of mbedtls_md5 or mbedtls_sha1: - warning: src/utils/sha1.h,62,error,danglingTemporaryLifetime,Using pointer that is a temporary. - warning: src/utils/sha1.h,60,style,constVariablePointer,Variable 'ret' can be declared as pointer to const - See https://github.com/owasp-modsecurity/ModSecurity/pull/3231#issuecomment-2312511500 Eduardo Arias 2024-08-28 12:19:58 -03:00
• bbef22b3b5 Added const reported by cppcheck 2.14 Eduardo Arias 2024-04-28 21:23:43 -03:00
• d053ec6de6 Add cppcheck suppressions for false positives Eduardo Arias 2024-08-21 08:32:28 -07:00
• c2b86ddc49 Suppress warnings on seclang-parser.hh warning: seclang-parser.hh,2116,warning,duplInheritedMember,The struct 'basic_symbol < by_kind >' defines member function with name 'clear' also defined in its parent struct 'by_kind'. warning: seclang-parser.hh,2376,warning,duplInheritedMember,The struct 'basic_symbol < by_kind >' defines member function with name 'type_get' also defined in its parent struct 'by_kind'. warning: seclang-parser.hh,2116,warning,duplInheritedMember,The struct 'basic_symbol < by_state >' defines member function with name 'clear' also defined in its parent struct 'by_state'. warning: seclang-parser.hh,2120,style,constVariableReference,Variable 'yysym' can be declared as reference to const Eduardo Arias 2024-04-29 00:37:36 -03:00
• 7d9c80dede Address cppcheck warnings: uselessOverride (The function '...' overrides a function in a base class but is identical to the overridden function) Eduardo Arias 2024-04-28 23:40:50 -03:00
• da38f20e19 Added missing override keyword as reported by cppcheck 2.14 Eduardo Arias 2024-04-28 22:25:17 -03:00
• 1eed8b9288 Ignore cppcheck warnings: normalCheckLevelMaxBranches (Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.) Eduardo Arias 2024-04-28 22:19:43 -03:00
• 193a0002e4 Updated cppcheck config - Do not scan third-party libraries (others dir) - Use standard C++17 for checks (defaults to C++20) Eduardo Arias 2024-08-20 15:10:19 -07:00
• e0c58233ad Use latest version of cppcheck (2.14.2) - Run cppcheck on MacOS to use a newer version of cppcheck Eduardo Arias 2024-04-28 17:45:54 -03:00
• ec506daaef Merge pull request #3280 from eduar-hte/range-checked-at Ervin Hegedus 2024-10-19 11:06:37 +02:00
• dfcf31a41f Merge pull request #3279 from marcstern/v2/PR/PCRE2_error_msg Ervin Hegedus 2024-10-19 10:47:39 +02:00
• ecab91a74e Add problematic pattern when DEBUG_CONF is defined Marc Stern 2024-10-17 14:43:03 +02:00
• 89ff91dae3 Fixed PCRE2 error message Marc Stern 2024-10-17 14:10:56 +02:00
• 0613ceeb75 Replace usage of range-checked 'at' method when vector/string has already been size checked Eduardo Arias 2024-06-02 20:07:19 +00:00
• 99ce9779e6 Merge pull request #3253 from eduar-hte/rule-message Ervin Hegedus 2024-10-15 18:13:31 +02:00
• 75d31a4d1e Simplified lifetime management of tests - Addresses Sonarcloud issues: - Rewrite the code so that you no longer need this "delete". - Make the type of this variable a reference-to-const. Eduardo Arias 2024-09-10 14:32:38 -03:00
• b7b2d9a40d Minor codebase improvements suggested by Sonarcloud - src/modsecurity.cc - Replace the redundant type with "auto". - src/transaction.cc - Avoid this unnecessary copy by using a "const" reference. - test/common/custom_debug_log.cc - Use "=default" instead of the default implementation of this special member functions. - Removed the unnecessary destructor override instead. - Annotate this function with "override" or "final". - Removed the unnecessary destructor override instead. - Remove this "const" qualifier from the return type in all declarations. - test/common/modsecurity_test_context.h - Replace the redundant type with "auto". - test/regression/regression.cc - Use the "nullptr" literal. - Replace this declaration by a structured binding declaration. - Replace "reinterpret_cast" with a safer operation. Eduardo Arias 2024-09-10 14:47:00 -03:00
• 4df297b596 Avoid passing RuleMessage by std::shared_ptr and use a reference instead. - Avoids copying std::shared_ptr when lifetime of the RuleMessage is controlled by the caller. - The RuleMessage instance is created in RuleWithActions::evaluate and then used to call the overloaded version of this method that is specialized by subclasses. - Once the call to the overloaded method returns, the std::shared_ptr is destroyed as it's not stored by any of the callers, so it can be replaced with a stack variable and avoid paying the cost of copying the std::shared_ptr (and its control block that is guaranteed to be thread-safe and thus is not a straightforward pointer copy) - Introduced RuleMessage::reset because this is required by RuleWithActions::performLogging when it's not the 'last log', the rule has multimatch and it's to be logged. - The current version is creating allocating another instance of RuleMessage on the heap to copy the Rule & Transaction related state while all the other members in the RuleMessage are set to their default values. - The new version leverages the existent, unused and incomplete function 'clean' (renamed as 'reset') to do this on the current instance. - Notice that the current code preserves the value of m_saveMessage, so 'reset' provides an argument for the caller to control whether this member should be reinitialized. eduar-hte 2024-05-06 01:24:52 +00:00
• e313ac7de7 Introduce ModSecurityTestContext to encapsulate setup of objects required to execute transactions - Simplifies memory management on error conditions - Context will be used in unit tests too, in order to provide Transaction related instances. eduar-hte 2024-05-07 01:29:16 +00:00
• d7f2be60ce Merge pull request #3270 from Marcool04/v2/master Marc Stern 2024-10-04 16:30:29 +02:00
• 4919814a5c make rootpath and incpath consts so apr_filepath_root doesn't cause incompatible pointer type Mark t480 2024-10-04 15:48:12 +02:00
• 1121ef0bed Merge pull request #3269 from marcstern/v2/pr/apr_mutex_create Ervin Hegedus 2024-10-03 13:44:34 +02:00
• 36a4194f46 CHANGES Marc Stern 2024-10-03 12:59:48 +02:00
• 23e3cb491a Fix for #3255 We don't have to generate a temp name ourselves, it'll be done in apr_global_mutex_create(). We don't have to provide a filename, apr_global_mutex_create() generates one automatically. Moreover, under Unix & Windows, the preferred mechanism won't use a file at all. apr_file_mktemp() cannot be used as it creates the file (at least on FreeBSD). Discussion in Apache mailing list: https://lists.apache.org/thread/ykb26kg4lgcqnldvxwd9p6hv16fy4z9l Marc Stern 2024-10-03 12:42:23 +02:00
• 9666663867 Merge pull request #3267 from airween/v2/modsecdefconf Ervin Hegedus 2024-10-03 09:59:55 +02:00
• 9a1155ca26 Merge pull request #3254 from eduar-hte/make_shared Ervin Hegedus 2024-10-02 17:23:48 +02:00
• 63d5d92565 chore: add 'log' action to rule 200005 Ervin Hegedus 2024-10-02 17:11:01 +02:00
• 090e4d3baa Merge pull request #3257 from marcstern/v2/pr/msr_global_mutex_lock Marc Stern 2024-10-02 17:09:51 +02:00
• 373ddb8925 Merge pull request #3266 from airween/v3/modsecdefconf Ervin Hegedus 2024-10-02 17:09:31 +02:00
• 63201ae39f chore: add 'log' action to rule 200005 Ervin Hegedus 2024-10-02 16:33:56 +02:00
• d6f1ebb4a3 Merge pull request #3265 from rainerjung/v2/move-id_log-to-msc_util Marc Stern 2024-10-02 13:00:00 +02:00
• 7737594edf Merge pull request #3264 from xuruidong/logo2 Ervin Hegedus 2024-10-02 09:08:58 +02:00
• 149376377e Move id_log() to msc_util to fix unit tests; it is declared on msc_util.h already Rainer Jung 2024-10-01 13:58:22 +02:00
• c99d931f3c Initialize filename to NULL Marc Stern 2024-09-30 13:53:31 +02:00
• 7a1480a506 Merge branch 'v2/pr/msr_global_mutex_lock' of https://github.com/marcstern/ModSecurity into v2/pr/msr_global_mutex_lock Marc Stern 2024-09-30 13:17:04 +02:00
• b8e8e30730 Fixed parameters/functions names Marc Stern 2024-09-30 13:12:38 +02:00
• 9238b0ced0 docs: add a logo picture for github dark theme xuruidong 2024-09-29 19:42:58 +08:00
• 95dc5944d4 Updated log message Marc Stern 2024-09-27 09:27:29 +02:00
• 339d6df2a5 Updated comment Marc Stern 2024-09-27 09:26:58 +02:00
• 02ca247283 Merge pull request #3262 from marcstern/v2/pr/time.h Ervin Hegedus 2024-09-25 20:50:30 +02:00
• 9ba1caa2fa Missing #include <time.h> Marc Stern 2024-09-25 13:57:05 +02:00
• bd54f01cd3 Added CHANGES Marc Stern 2024-09-20 12:51:03 +02:00
• b850c74b12 We should have get the warning at lock time, so ignore it at unlock time Marc Stern 2024-09-12 14:07:55 +02:00
• 449c080e63 Same for global_mutex_unlock Marc Stern 2024-09-12 13:01:44 +02:00
• b52201010d msr_global_mutex_lock: Handle errors from apr_global_mutex_lock Marc Stern 2024-09-12 12:18:25 +02:00
• c6c06c4f33 leverage std::make_unique & std::make_shared - Simpler code & more efficient because control block can be allocated with object. Eduardo Arias 2024-05-05 13:06:50 -03:00
• 9e02b3cf01 Merge pull request #3248 from eduar-hte/simplified-constructors Ervin Hegedus 2024-09-09 16:14:09 +02:00
• 6ecfee7ab7 Simplify and reduce code duplication in Transaction constructors - Leverage delegating constructor to avoid code duplication between the two available Transaction constructors. - The constructor without 'id' argument delegates to the one that receives it by providing nullptr as a value, which is used to flag that an id needs to be generated. - Simplified constructor by removing member initialization where the default constructor will be invoked. Eduardo Arias 2024-09-03 17:43:48 -03:00
• 2c613fb77c Simplify initialization of fileName member of Rule instances Eduardo Arias 2024-05-06 01:39:55 -03:00
• 2ad87f640f Reference RuleWithActions & Transaction object instead of copying values in RuleMessage - Because the lifetime of the RuleMessage instances do not extend beyond the lifetime of the enclosing RuleWithActions & Transaction, RuleMessage can just reference it and simplify its definition. - Additionally, make the references const to show that it doesn't modify it. - Replace RuleMessage copy constructor with default implementations. - Removed unused RuleMessage assignment operator (which cannot be implemented now that it has reference members). - Removed constructor from RuleMessage pointer. - Addressed Sonarcloud suggestions: Do not use the constructor's initializer list for data member "xxx". Use the in-class initializer instead. Eduardo Arias 2024-05-05 15:15:47 -03:00
• 2ec640fd76 Delete unused copy constructor & assignment operator in Rule, RuleMarker & Action - Declare other unsupported copy constructor & assignment operators as deleted too (RuleWithActions, RuleUnconditional & RuleScript) Eduardo Arias 2024-06-02 02:03:34 +00:00
• 0e6fc62548 Merge pull request #3250 from airween/v2/literalbuildfix Ervin Hegedus 2024-09-04 10:55:02 +02:00
• 38e812d197 Add -Werror=format-security CFLAG for all build case Ervin Hegedus 2024-09-03 21:50:22 +02:00
• cddd9a7eb5 Fix build error if -Werror=format-security is presented Ervin Hegedus 2024-09-03 21:49:43 +02:00
• 580fe192df Merge pull request #3247 from airween/v3/master v3.0.13 Ervin Hegedus 2024-09-03 15:44:47 +02:00
• 24dbcfe637 Change release version to v3.0.13 Ervin Hegedus 2024-09-03 15:24:29 +02:00
• 1a8c96a1cd Merge pull request #3206 from airween/v3/release2408 Ervin Hegedus 2024-09-03 15:20:34 +02:00
• b5179a110a Merge pull request #3245 from airween/v2/release2409 Ervin Hegedus 2024-09-03 14:49:58 +02:00
• ad0161118d Change release version to v2.9.8 v2.9.8 Ervin Hegedus 2024-09-03 14:40:55 +02:00
• bf1a3be793 Merge pull request #3205 from airween/v2/release2408 Ervin Hegedus 2024-09-03 14:37:48 +02:00
• b489fd3562 Format fix Ervin Hegedus 2024-09-03 07:45:09 +02:00
• c9fe84ea2c Typo fixes Ervin Hegedus 2024-09-03 07:42:20 +02:00
• 2ab970be2e Finalize CHANGES Ervin Hegedus 2024-09-02 22:23:19 +02:00
• 25d73b71c8 Finalize CHANGES Ervin Hegedus 2024-09-02 22:21:08 +02:00
• 865b75b8fa Merge branch 'owasp-modsecurity:v3/master' into v3/release2408 Ervin Hegedus 2024-08-28 16:37:12 +02:00
• 542a5ea35c Added PR #3243 Ervin Hegedus 2024-08-28 16:08:23 +02:00
• f180e647a1 Merge pull request #3243 from eduar-hte/valid-hex-fix Ervin Hegedus 2024-08-28 16:07:44 +02:00
• a4604b66f7 Added new tests to op @pm Ervin Hegedus 2024-08-28 15:17:38 +02:00
• 27cc8edbfe Adjust reference to modsecurity::utils::string::VALID_HEX - This function (previously a #define) was previously in the global namespace and was moved into modsecurity::utils::string in commit a6d64bf. Eduardo Arias 2024-08-28 10:13:12 -03:00
• 358618951a Added PR #3240 Ervin Hegedus 2024-08-28 14:37:56 +02:00
• 9403cf6f5d Merge pull request #3240 from frozenice/patch-1 Ervin Hegedus 2024-08-28 14:36:36 +02:00