Ervin Hegedus
7f4e416fc4
Added PR #3202
2024-08-18 22:59:22 +02:00
Ervin Hegedus
e7e11d972f
Merge pull request #3202 from marcstern/v2/pr/assert
...
Fixed assert() usage
2024-08-18 22:58:06 +02:00
Marc Stern
60d07a5547
added one more NULL check at run-time
2024-08-16 09:23:11 +02:00
Marc Stern
4edeca70e4
Added "::error" in error message
2024-08-14 19:12:03 +02:00
Marc Stern
4b391834ec
added more NULL checks at run-time
2024-08-14 19:09:15 +02:00
Marc Stern
0066a67911
added more NULL checks at run-time
2024-08-14 19:00:25 +02:00
Marc Stern
22a6829690
added more NULL checks at run-time
2024-08-14 18:44:45 +02:00
Marc Stern
e5bbd89399
re-added some NULL check at run-time, with an error message on stderr
2024-08-14 13:53:52 +02:00
Marc Stern
1680f5be90
removed comment
2024-08-14 12:56:59 +02:00
Ervin Hegedus
04dff87623
Added PR #3193
2024-08-14 10:59:56 +02:00
Ervin Hegedus
277e7e2bf6
Merge pull request #3193 from marcstern/v2/pr/useless
...
Removed useless code
2024-08-14 10:59:03 +02:00
Ervin Hegedus
0a9e0aa67b
Added PR #3226
2024-08-14 09:32:08 +02:00
Ervin Hegedus
8cfb9112fb
Merge pull request #3226 from airween/v2/mpinvcharreqbody
...
feat: Check if the MP header contains invalid character
2024-08-14 09:31:20 +02:00
Ervin Hegedus
ffecae98d3
Update CHANGES
2024-08-13 19:35:17 +02:00
Ervin Hegedus
e6e3417e9d
Remove unnecessary assert()
2024-08-13 11:07:44 +02:00
Ervin Hegedus
f27c85cf47
Check if the MP header contains invalid character
2024-08-13 11:07:18 +02:00
Ervin Hegedus
935e68c816
Merge pull request #3192 from marcstern/v2/pr/errorlog
...
Use standard httpd logging format in error log
2024-08-12 17:17:15 +02:00
Marc Stern
d32c8f1ad8
Fixed invalid logging
2024-08-12 17:06:35 +02:00
Ervin Hegedus
914c1a1cb2
Merge pull request #3194 from marcstern/v2/pr/PCRE_ERROR_NOMATCH
...
msc_regexec() != PCRE_ERROR_NOMATCH
2024-08-12 16:40:40 +02:00
Marc Stern
d704af657c
Define _FORTIFY_SOURCE=3 & _GLIBCXX_ASSERTIONS that add glibc/libstdc++ assertions.
...
See https://www.gnu.org/software/libc/manual/html_node/Source-Fortification.html & https://gcc.gnu.org/wiki/LibstdcxxDebugMode
_GLIBCXX_ASSERTIONS is probably useless as we have pure C here, but let's define it in case some checks are included (or will be in a future version).
As we handle some requests here, that may help to trap a problem.
2024-08-08 16:16:14 +02:00
Marc Stern
7126574bb2
Merge branch 'v2/pr/errorlog' of https://github.com/marcstern/ModSecurity into v2/pr/errorlog
2024-08-07 17:01:32 +02:00
Marc Stern
686a74173f
# Send some requests & check log format
2024-08-07 17:01:20 +02:00
Marc Stern
692710cab7
Replaced 0 by '\0' for char
2024-08-07 13:45:09 +02:00
Marc Stern
8dd5d5f46b
re_operators.c: removed invalid check (done correctly on line 1067)
...
copy_rules(): only one return code => void
2024-08-07 09:42:40 +02:00
Ervin Hegedus
ccebb58c94
Add PR's to CHANGES
2024-08-03 16:22:45 +02:00
Marc Stern
cb11716af7
Merge branch 'v2/master' of https://github.com/marcstern/ModSecurity into v2/pr/assert
2024-08-02 17:52:01 +02:00
Marc Stern
5de53cc728
handles the case grep doesn't match, otherwise the script exits with 1 (error)
2024-08-02 12:11:16 +02:00
Marc Stern
f5bbb0b851
Fixed exit code in case of success
2024-08-02 11:43:09 +02:00
Marc Stern
4399ee9ba9
Fixed quotes
2024-08-02 11:28:07 +02:00
Marc Stern
8723294cd1
Search for errors/warnings in error log and stop if found
2024-08-02 11:19:34 +02:00
Ervin Hegedus
e4245986bf
Merge pull request #3198 from marcstern/v2/pr/collection_store_log
...
Add collection size in log in case of writing error
2024-07-31 18:20:46 +02:00
Marc Stern
7c379c8d59
Fixed assert() usage:
...
- added some missing
- removed some invalid
- removed some that were not relevant in the context of the current function, when done in a called function
2024-07-31 11:17:36 +02:00
Marc Stern
0be1f1566a
Remove redundant entry
...
[client %s] is added by the standard httpd log function => remove it
2024-07-31 09:38:20 +02:00
Ervin Hegedus
df79bf6843
Merge pull request #3187 from marcstern/v2/pr/logidptr
...
Invalid pointer access in case rule id == NOT_SET_P
2024-07-30 16:25:54 +02:00
Ervin Hegedus
36601843b2
Merge pull request #3199 from airween/v2/xmlfreefix
...
Move xmlFree() call to the right place
2024-07-26 09:14:04 +02:00
Ervin Hegedus
223ce91aee
Move xmlFree() call to the right place
2024-07-25 20:52:55 +02:00
Ervin Hegedus
824e523a48
Merge pull request #3188 from marcstern/v2/pr/acquire_global_lock
...
Passing address of lock instead of lock in acquire_global_lock()
2024-07-25 14:20:00 +02:00
Marc Stern
f143663cf0
Add collection in log in case of writing error
2024-07-25 09:30:48 +02:00
Marc Stern
73a79af593
Fixed duplicate log entry
...
use ap_log_error() if msr is NULL
Fixed indentation
2024-07-25 08:55:26 +02:00
Marc Stern
b53c2277d7
removed duplicate log entry
2024-07-25 08:39:44 +02:00
Marc Stern
9b987cc3f9
Return of msc_regexec() compared with PCRE_ERROR_NOMATCH (!=) to check if match.
...
Other errors may happen that would return -2, -3, ...
Matching would be incorrectly set in this case.
We must check if >= 0
2024-07-22 17:08:16 +02:00
Marc Stern
cd65a44d64
Removed useless code
2024-07-22 16:53:58 +02:00
Marc Stern
f32be70793
Use standard httpd logging format in error log
2024-07-22 16:24:56 +02:00
Marc Stern
a32b512a7f
Systematically log problems in update_rule_target_ex().
...
Fix some memory leaks in update_rule_target_ex().
2024-07-22 15:59:28 +02:00
Marc Stern
243d9c978a
Log audit lock name in case of problem
2024-07-22 15:57:15 +02:00
Marc Stern
ee9a2353a5
create audit log
2024-07-22 15:29:45 +02:00
Marc Stern
9808ce47c5
CI improvement: First check syntax & always display error/audit logs
2024-07-22 15:23:51 +02:00
Marc Stern
ca593a4a40
Passing address of lock instead of lock in acquire_global_lock()
2024-07-20 18:53:30 +02:00
Marc Stern
9fb773c1ce
Invalid pointer access in case rule id == NOT_SET_P
2024-07-20 18:45:14 +02:00
Ervin Hegedus
28b6e1d7d0
Merge pull request #3171 from marcstern/v2/ci_errorlog
...
Show error.log after httpd start in CI
2024-06-12 15:08:47 +02:00