19 Commits

Author SHA1 Message Date
martinhsv
1f350296ba
Implement id ranges for ctl:ruleRemoveTargetById 2020-10-29 13:57:44 -03:00
Felipe Zimmerle
abf59f4b84
Refactoring on Action - having RuleWithAction and RuleWithActionsProperties 2020-10-29 13:44:13 -03:00
Felipe Zimmerle
6be58b1eba
Reduce the workload on VariableValue
Last compute at the last minute, if needed.
2020-10-29 13:44:11 -03:00
Felipe Zimmerle
5a0e71fdc0
Replaces getKeyWithCollection with getName on VariableValue 2020-10-29 13:44:10 -03:00
Felipe Zimmerle
aaffd314e5
Delays variable name resolution to whenever it is necessary 2020-10-29 13:44:09 -03:00
Felipe Zimmerle
de9b5b2f16
Cosmetics: Using VariableValues instead of std::vector<...>
Making the code more readable.
2020-10-29 13:44:09 -03:00
Felipe Zimmerle
d991461c43
Refactoring on variables::Variable
Using the references on key and collection as shared pointers
2020-10-29 13:44:09 -03:00
WGH
21a63b296a
Use std::shared_ptr for variable resolution
AnchoredSetVariable::resolve is called for every rule
(see RuleWithOperator::evaluate). The previous implementation allocated
a new copy of every variable, which quickly added up. In my tests,
AnchoredSetVariable::resolve function consumed 7.8% of run time.

AnchoredSetVariable (which is a multimap) values are never changed,
only added. This means it's safe to store them in std::shared_ptr,
and make resolve return shared_ptr pointing to the same object.

Other resolve implementation could also use this optimization by not
allocating new objects, however, they are not hot spots, so this
optimization was not implemented there.

In my benchmark, this raises performance from 117 requests per second to
131 RPS, and overhead is lowered from 7.8% to 2.4%.

As a bonus, replacing plain pointer with smart pointers make code
cleaner, since using smart pointers makes manual deletes no longer necessary.

Additionally, VariableOrigin is now stored in plain std::vector,
since it's wasteful to store structure containing just two integer
values using std::list<std::unique_ptr<T>>.
2020-10-29 13:44:08 -03:00
Felipe Zimmerle
d393b4734b
Makes RuleWithActions const in run time operations 2020-10-29 13:44:07 -03:00
Felipe Zimmerle
67b08dfe43
actions: Compute the rule association during rules load 2020-10-29 13:44:04 -03:00
Felipe Zimmerle
af23c720ae
Makes operator to use string_view 2020-10-29 13:44:03 -03:00
Felipe Zimmerle
c9204a1c1f
Moves rule* headers to src/ 2020-10-29 13:44:02 -03:00
Felipe Zimmerle
6547f3601f
Refactoring: Makes transformations to work with new execute signature 2020-10-29 13:44:01 -03:00
Felipe Zimmerle
35a341e473
Refactoring in the Rule class to make it more elegant 2020-10-29 13:43:59 -03:00
Felipe Zimmerle
0daeb09b0a
Adds new method for rule merge
IMPORTANT: SecDefaultAction specified on a child configuration will
overwrite the ones specified on the parent; Previously it was
concatenating.
2020-10-29 13:43:54 -03:00
Felipe Zimmerle
ae3ad5eaa7
cosmetics: Address some cppcheck complains 2020-08-06 19:02:00 -03:00
Felipe Zimmerle
7e0bc26917
Using performLogging function 2020-03-31 15:20:15 -03:00
Felipe Zimmerle
7a48245aed
Creates RuleUnconditional
Makes RuleScript child of RuleWithActions instead of Operator
2020-03-31 14:44:19 -03:00
Felipe Zimmerle
f63bd1a45d
Moves Rule[WithActions|WithOperator] to their own files 2020-03-31 13:33:38 -03:00