- Parser location is now a custom class. It holds a shared pointer
with the file name; If the parser fails, the resource is deleted.
- To follow the parser change, the Rule class now holds the file
name in a shared pointer instead of a unique pointer. As a shared
pointer we avoid duplication of the file name in memory, plus,
it frees itself when not in use anymore.
- Operator init also accepting the filename as a shared pointer.
- Driver is treating m_location was privative. Now it holds a
std::list<std::shared_ptr<yy::seclang_parser::location_type>>
instead of: std::list<yy::seclang_parser::location_type *>.
- Fix: addSecRule on Driver() was changed from RuleWithAction to
RuleWithOperator.
- Minor changes on the regression and rules-check utility to force
deletion of resources even when they fail.
- Couple of virtual destructors were placed to force the shared
pointer decrementing on shared variables.
- Deleted constructors for copy were placed for the sake of
readability.
This commit fixes quite a few odd things in regex code:
* Lack of encapsulation.
* Non-method functions for matching without retrieving all groups.
* Regex class being copyable without proper copy-constructor (potential UAF
and double free due to pointer members m_pc and m_pce).
* Redundant SMatch::m_length, which always equals to match.size() anyway.
* Weird SMatch::size_ member which is initialized only by one of the three matching
functions, and equals to the return value of that function anyways.
* Several places in code having std::string value instead of reference.
C++ regex library proven to be unusable for gcc 4.8 and earlier version, so
reimplement code using PCRE library in order to build workable version of
unit_test executable for CentOS 7, RHEL 7, Ubuntu 14 and SUSE Linux 12.
