Cosmetics: address cppcheck warnings

src/audit_log/audit_log.cc

@@ -54,12 +54,12 @@ AuditLog::AuditLog()
     : m_path1(""),
     m_path2(""),
     m_storage_dir(""),
+    m_format(NotSetAuditLogFormat),
+    m_parts(-1),
     m_filePermission(-1),
     m_directoryPermission(-1),
-    m_parts(-1),
     m_status(NotSetLogStatus),
     m_type(NotSetAuditLogType),
-    m_format(NotSetAuditLogFormat),
     m_relevant(""),
     m_writer(NULL),
     m_refereceCount(1) { }
@@ -85,7 +85,7 @@ bool AuditLog::setFileMode(int permission) {
 }
 
 
-int AuditLog::getFilePermission() {
+int AuditLog::getFilePermission() const {
     if (m_filePermission == -1) {
         return m_defaultFilePermission;
     }
@@ -93,7 +93,7 @@ int AuditLog::getFilePermission() {
     return m_filePermission;
 }
 
-int AuditLog::getDirectoryPermission() {
+int AuditLog::getDirectoryPermission() const {
     if (m_directoryPermission == -1) {
         return m_defaultDirectoryPermission;
     }
@@ -192,7 +192,7 @@ bool AuditLog::setParts(const std::basic_string<char>& new_parts) {
 }
 
 
-int AuditLog::getParts() {
+int AuditLog::getParts() const {
     if (m_parts == -1) {
         return m_defaultParts;
     }

src/audit_log/writer/parallel.h

@@ -65,7 +65,7 @@ class Parallel : public Writer {
      YearMonthDayAndTimeFileName = 8,
     };
 
-    inline std::string logFilePath(time_t *t, int part);
+    static inline std::string logFilePath(time_t *t, int part);
 };
 
 }  // namespace writer

src/audit_log/writer/writer.h

@@ -51,7 +51,7 @@ class Writer {
     virtual bool write(Transaction *transaction, int parts,
         std::string *error) = 0;
 
-    void generateBoundary(std::string *boundary);
+    static void generateBoundary(std::string *boundary);
 
     void refCountIncrease() {
         m_refereceCount++;