github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-14 13:56:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Removed unnecessary cppcheck suppression and r-value reference as copy should be avoidded by RVO

Browse Source
This commit is contained in:
Eduardo Arias 2024-04-27 18:00:28 -03:00
parent b872f11f68
commit fde9d279b0
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modsecurity.cc
View File

@ -202,7 +202,7 @@ void ModSecurity::serverLog(void *data, std::shared_ptr<RuleMessage> rm) {
} }
if (m_logProperties & TextLogProperty) { if (m_logProperties & TextLogProperty) {
std::string &&d = rm->log(); auto d = rm->log();
const void *a = static_cast<const void *>(d.c_str()); const void *a = static_cast<const void *>(d.c_str());
m_logCb(data, a); m_logCb(data, a);
return; return;

2
test/cppcheck_suppressions.txt
View File

@ -44,12 +44,10 @@ functionStatic:src/engine/lua.h:71
functionConst:src/utils/geo_lookup.h:49 functionConst:src/utils/geo_lookup.h:49
useInitializationList:src/operators/rbl.h:69 useInitializationList:src/operators/rbl.h:69
constStatement:test/common/modsecurity_test.cc:82 constStatement:test/common/modsecurity_test.cc:82
danglingTemporaryLifetime:src/modsecurity.cc:206
functionStatic:src/operators/geo_lookup.h:35 functionStatic:src/operators/geo_lookup.h:35
duplicateBreak:src/operators/validate_utf8_encoding.cc duplicateBreak:src/operators/validate_utf8_encoding.cc
syntaxError:src/transaction.cc:62 syntaxError:src/transaction.cc:62
noConstructor:src/variables/variable.h:152 noConstructor:src/variables/variable.h:152
danglingTempReference:src/modsecurity.cc:206
knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77 knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77
knownConditionTrueFalse:src/operators/verify_svnr.cc:87 knownConditionTrueFalse:src/operators/verify_svnr.cc:87
rethrowNoCurrentException:headers/modsecurity/transaction.h:313 rethrowNoCurrentException:headers/modsecurity/transaction.h:313