From fd67c6eb1db0c70dc3d9617180a142830c1cc4e5 Mon Sep 17 00:00:00 2001 From: Martin Vierula Date: Wed, 25 Oct 2023 06:07:26 -0700 Subject: [PATCH] Remove unneeded heap allocation in AnchoredSetVariable::set --- src/anchored_set_variable.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/anchored_set_variable.cc b/src/anchored_set_variable.cc index 32bddf88..ec087775 100644 --- a/src/anchored_set_variable.cc +++ b/src/anchored_set_variable.cc @@ -53,9 +53,7 @@ void AnchoredSetVariable::unset() { void AnchoredSetVariable::set(const std::string &key, const std::string &value, size_t offset, size_t len) { std::unique_ptr origin(new VariableOrigin()); - std::string *v = new std::string(value); - VariableValue *var = new VariableValue(&m_name, &key, v); - delete v; + VariableValue *var = new VariableValue(&m_name, &key, &value); origin->m_offset = offset; origin->m_length = len; @@ -68,9 +66,7 @@ void AnchoredSetVariable::set(const std::string &key, void AnchoredSetVariable::set(const std::string &key, const std::string &value, size_t offset) { std::unique_ptr origin(new VariableOrigin()); - std::string *v = new std::string(value); - VariableValue *var = new VariableValue(&m_name, &key, v); - delete v; + VariableValue *var = new VariableValue(&m_name, &key, &value); origin->m_offset = offset; origin->m_length = value.size();