github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-14 13:56:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential buffer overrun by 1 byte in base64Decode caused by bad docs from APR-Util. See #255.

Browse Source
This commit is contained in:
brectanus 2007-09-21 00:20:31 +00:00
parent b217e42624
commit eb6b456f5b
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -1,6 +1,9 @@
?? ??? 2007 - 2.5.0-dev3 ?? ??? 2007 - 2.5.0-dev3
------------------------ ------------------------
* Fixed potential corruption at end of strings after using base64Decode
(APR-Util issue). TODO make a better CHANGELOG entry ;)
* Return from the output filter with an error in addition to setting * Return from the output filter with an error in addition to setting
up the HTTP error status in the output data. up the HTTP error status in the output data.

3
apache2/re_tfns.c
View File

@ -311,8 +311,7 @@ static int msre_fn_base64Decode_execute(apr_pool_t *mptmp, unsigned char *input,
{ {
*rval_len = apr_base64_decode_len((const char *)input); /* returns len with NULL byte included */ *rval_len = apr_base64_decode_len((const char *)input); /* returns len with NULL byte included */
*rval = apr_palloc(mptmp, *rval_len); *rval = apr_palloc(mptmp, *rval_len);
apr_base64_decode(*rval, (const char *)input); *rval_len = apr_base64_decode(*rval, (const char *)input);
(*rval_len)--;
return 1; return 1;
} }