github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-14 05:45:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix two rule-reload memory leak issues

Browse Source
This commit is contained in:
Martin Vierula 2022-09-15 13:44:40 -07:00
parent 17f3bb0b36
commit e9a7ba4a60
4 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES
View File

@ -1,6 +1,8 @@
v3.x.y - YYYY-MMM-DD (to be released) v3.x.y - YYYY-MMM-DD (to be released)
------------------------------------- -------------------------------------
- Fix two rule-reload memory leak issues
[Issue #2801 - @Abce, @martinhsv]
- Correct whitespace handling for Include directive - Correct whitespace handling for Include directive
[Issue #2800 - @877509395, @martinhsv] [Issue #2800 - @877509395, @martinhsv]

2
headers/modsecurity/rule.h
View File

@ -86,6 +86,8 @@ class Rule {
return *this; return *this;
} }
virtual ~Rule() {}
virtual bool evaluate(Transaction *transaction) = 0; virtual bool evaluate(Transaction *transaction) = 0;
virtual bool evaluate(Transaction *transaction, virtual bool evaluate(Transaction *transaction,

4
src/rule_with_actions.cc
View File

@ -80,6 +80,10 @@ RuleWithActions::RuleWithActions(
m_containsStaticBlockAction(false), m_containsStaticBlockAction(false),
m_isChained(false) { m_isChained(false) {
if (transformations != NULL) {
delete transformations;
}
if (actions) { if (actions) {
for (Action *a : *actions) { for (Action *a : *actions) {
if (a->action_kind == Action::ConfigurationKind) { if (a->action_kind == Action::ConfigurationKind) {

8
test/cppcheck_suppressions.txt
View File

@ -55,8 +55,8 @@ danglingTempReference:src/modsecurity.cc:206
knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77 knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77
knownConditionTrueFalse:src/operators/verify_svnr.cc:87 knownConditionTrueFalse:src/operators/verify_svnr.cc:87
rethrowNoCurrentException:headers/modsecurity/transaction.h:309 rethrowNoCurrentException:headers/modsecurity/transaction.h:309
rethrowNoCurrentException:src/rule_with_actions.cc:123 rethrowNoCurrentException:src/rule_with_actions.cc:127
ctunullpointer:src/rule_with_actions.cc:237 ctunullpointer:src/rule_with_actions.cc:241
ctunullpointer:src/rule_with_operator.cc:135 ctunullpointer:src/rule_with_operator.cc:135
ctunullpointer:src/rule_with_operator.cc:95 ctunullpointer:src/rule_with_operator.cc:95
passedByValue:src/variables/global.h:109 passedByValue:src/variables/global.h:109
@ -93,6 +93,10 @@ functionStatic
variableScope variableScope
shadowFunction shadowFunction
constVariable
stlcstrConstructor
stlcstrStream
uselessCallsSubstr
// Examples // Examples
memleak:examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h:147 memleak:examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h:147