github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-09-30 11:44:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix assorted memory and static analysis errors

Browse Source
This commit is contained in:
Felipe Zimmerle
2017-01-31 17:15:31 -03:00
committed by Felipe Zimmerle
parent 8d0583eda4
commit e95efa05cc
62 changed files with 209 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/actions/set_var.cc
View File

@@ -17,6 +17,7 @@
#include <iostream>
#include <string>
#include <memory>
#include "modsecurity/transaction.h"
#include "modsecurity/rule.h"

2
src/actions/transformations/hex_decode.cc
View File

@@ -35,7 +35,7 @@ namespace transformations {
std::string HexDecode::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
int size = 0;
input = reinterpret_cast<unsigned char *>

8
src/actions/transformations/html_entity_decode.cc
View File

@@ -36,7 +36,7 @@ namespace transformations {
std::string HtmlEntityDecode::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));
@@ -98,7 +98,7 @@ int HtmlEntityDecode::inplace(unsigned char *input, u_int64_t input_len) {
}
if (j > k) { /* Do we have at least one digit? */
/* Decode the entity. */
char *x = NULL;
char *x;
x = reinterpret_cast<char *>(calloc(sizeof(char),
((j - k) + 1)));
memcpy(x, (const char *)&input[k], j - k);
@@ -124,7 +124,7 @@ int HtmlEntityDecode::inplace(unsigned char *input, u_int64_t input_len) {
}
if (j > k) { /* Do we have at least one digit? */
/* Decode the entity. */
char *x = NULL;
char *x;
x = reinterpret_cast<char *>(calloc(sizeof(char),
((j - k) + 1)));
memcpy(x, (const char *)&input[k], j - k);
@@ -150,7 +150,7 @@ int HtmlEntityDecode::inplace(unsigned char *input, u_int64_t input_len) {
j++;
}
if (j > k) { /* Do we have at least one digit? */
char *x = NULL;
char *x;
x = reinterpret_cast<char *>(calloc(sizeof(char),
((j - k) + 1)));
memcpy(x, (const char *)&input[k], j - k);

2
src/actions/transformations/js_decode.cc
View File

@@ -37,7 +37,7 @@ namespace transformations {
std::string JsDecode::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/parity_even_7bit.cc
View File

@@ -35,7 +35,7 @@ namespace transformations {
std::string ParityEven7bit::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/parity_odd_7bit.cc
View File

@@ -35,7 +35,7 @@ namespace transformations {
std::string ParityOdd7bit::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/parity_zero_7bit.cc
View File

@@ -35,7 +35,7 @@ namespace transformations {
std::string ParityZero7bit::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/remove_comments.cc
View File

@@ -35,7 +35,7 @@ namespace transformations {
std::string RemoveComments::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/sql_hex_decode.cc
View File

@@ -44,7 +44,7 @@ namespace transformations {
std::string SqlHexDecode::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
int size = 0;
input = reinterpret_cast<unsigned char *>

2
src/actions/transformations/url_decode_uni.cc
View File

@@ -38,7 +38,7 @@ namespace transformations {
std::string UrlDecodeUni::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
input = reinterpret_cast<unsigned char *>
(malloc(sizeof(char) * value.length()+1));

2
src/actions/transformations/utf8_to_unicode.cc
View File

@@ -36,7 +36,7 @@ namespace transformations {
std::string Utf8ToUnicode::evaluate(std::string value,
Transaction *transaction) {
std::string ret;
unsigned char *input = NULL;
unsigned char *input;
int changed = 0;
char *out;