github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-09-29 19:24:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Cosmetics: Fix some static analysis report

Browse Source
This commit is contained in:
Felipe Zimmerle
2016-11-29 10:27:51 -03:00
parent 9bd37ccb63
commit e6b58014db
15 changed files with 43 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/audit_log/audit_log.cc
View File

@@ -42,17 +42,17 @@ namespace modsecurity {
namespace audit_log {
AuditLog::AuditLog()
: m_status(OffAuditLogStatus),
m_path1(""),
: m_path1(""),
m_path2(""),
m_storage_dir(""),
m_filePermission(0600),
m_directoryPermission(0766),
m_parts(AAuditLogPart | BAuditLogPart | CAuditLogPart | FAuditLogPart
| HAuditLogPart | ZAuditLogPart),
m_status(OffAuditLogStatus),
m_type(ParallelAuditLogType),
m_writer(NULL),
m_relevant(""),
filePermission(0600),
directoryPermission(0766),
m_writer(NULL),
m_refereceCount(0) { }
AuditLog::~AuditLog() {
@@ -74,13 +74,13 @@ void AuditLog::refCountDecreaseAndCheck() {
}
bool AuditLog::setStorageDirMode(int permission) {
this->directoryPermission = permission;
this->m_directoryPermission = permission;
return true;
}
bool AuditLog::setFileMode(int permission) {
this->filePermission = permission;
this->m_filePermission = permission;
return true;
}

4
src/audit_log/audit_log.h
View File

@@ -166,8 +166,8 @@ class AuditLog {
std::string m_path2;
std::string m_storage_dir;
int filePermission;
int directoryPermission;
int m_filePermission;
int m_directoryPermission;
int m_parts;

6
src/audit_log/writer/parallel.cc
View File

@@ -114,13 +114,13 @@ bool Parallel::write(Transaction *transaction, int parts) {
utils::createDir((logPath +
logFilePath(&transaction->m_timeStamp, YearMonthDayDirectory)).c_str(),
m_audit->directoryPermission);
m_audit->m_directoryPermission);
utils::createDir((logPath +
logFilePath(&transaction->m_timeStamp, YearMonthDayDirectory
| YearMonthDayAndTimeDirectory)).c_str(),
m_audit->directoryPermission);
m_audit->m_directoryPermission);
fd = open(fileName.c_str(), O_CREAT | O_WRONLY, m_audit->filePermission);
fd = open(fileName.c_str(), O_CREAT | O_WRONLY, m_audit->m_filePermission);
if (fd < 0) {
return false;
}