From db298696fa9f6f8eb7a14c31ff914474b6e2f6c8 Mon Sep 17 00:00:00 2001 From: Ervin Hegedus Date: Thu, 23 May 2019 13:00:38 +0000 Subject: [PATCH] Adds missing check for runtime ctl:ruleRemoveByTag --- src/rules.cc | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/rules.cc b/src/rules.cc index f5b16cab..eff766f9 100644 --- a/src/rules.cc +++ b/src/rules.cc @@ -239,13 +239,18 @@ int Rules::evaluate(int phase, Transaction *t) { } } - for (auto &z : t->m_ruleRemoveByTag) { - if (rule->containsTag(z, t) == true) { - ms_dbg_a(t, 9, "Skipped rule id '" \ - + std::to_string(rule->m_ruleId) \ - + "'. Skipped due to a ruleRemoveByTag action."); - remove_rule = true; - break; + if (t->m_ruleRemoveByTag.empty() == false) { + for (auto &z : t->m_ruleRemoveByTag) { + if (rule->containsTag(z, t) == true) { + ms_dbg_a(t, 9, "Skipped rule id '" \ + + std::to_string(rule->m_ruleId) \ + + "'. Skipped due to a ruleRemoveByTag action."); + remove_rule = true; + break; + } + } + if (remove_rule) { + continue; } }