From 4393ce84964da884df25f8225d18e781c335c5a5 Mon Sep 17 00:00:00 2001
From: Hiroaki Nakamura <hnakamur@gmail.com>
Date: Sun, 28 Dec 2025 06:35:52 +0900
Subject: [PATCH 1/2] doc: Run make check instead of unit_tests

Tests in the following file are known to fail
when running the `unit_tests` executable at `test` directory:
test/test-cases/secrules-language-tests/transformations/phpArgsNames.json

Run `make check` at the top directory instead to ignore these failures.
(See https://github.com/owasp-modsecurity/ModSecurity/issues/3328)
---
 README.md | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/README.md b/README.md
index a60ed923..d5abea92 100644
--- a/README.md
+++ b/README.md
@@ -218,9 +218,7 @@ the utilities, follow the commands listed below:
 ```shell
 $ cd /path/to/your/ModSecurity
 $ git submodule foreach git pull
-$ cd test
-$ ./regression_tests
-$ ./unit_tests
+$ make check
  ```
 
 ### Debugging

From ac44a71d2b3818c9fb0490b7df5fabb6eff42ec0 Mon Sep 17 00:00:00 2001
From: Hiroaki Nakamura <hnakamur@gmail.com>
Date: Sun, 28 Dec 2025 06:41:35 +0900
Subject: [PATCH 2/2] doc: Fix README to update git submodules

The old instruction causes the following error:
```
$ git submodule foreach git pull
Entering 'bindings/python'
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

fatal: run_command returned non-zero status for bindings/python
.
```
---
 README.md    | 2 +-
 configure.ac | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index d5abea92..50b88333 100644
--- a/README.md
+++ b/README.md
@@ -217,7 +217,7 @@ the utilities, follow the commands listed below:
 
 ```shell
 $ cd /path/to/your/ModSecurity
-$ git submodule foreach git pull
+$ git submodule update --init --recursive
 $ make check
  ```
 
diff --git a/configure.ac b/configure.ac
index 7a78bb6c..31097b02 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,8 +68,7 @@ AC_MSG_ERROR([\
 
   You can download libInjection using git:
 
-     $ git submodule init
-     $ git submodule update
+     $ git submodule update --init --recursive
 
    ])
 fi
@@ -90,8 +89,7 @@ AC_MSG_ERROR([\
 
   You can download Mbed TLS using git:
 
-     $ git submodule init
-     $ git submodule update
+     $ git submodule update --init --recursive
 
    ])
 fi