github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-13 21:36:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove cppcheck suppression by replacing use of local variable to alias this->m_variables

Browse Source 
- The name of the local variable would clash with the namespace of the
  same name, which may have lead cppcheck to think the variable was not
  used.
This commit is contained in:
Eduardo Arias 2024-10-21 15:30:23 -03:00
parent ce9a3167fa
commit cdaf32f521
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/rule_with_operator.cc
View File

@ -203,7 +203,6 @@ inline void RuleWithOperator::getFinalVars(variables::Variables *vars,
bool RuleWithOperator::evaluate(Transaction *trans, bool RuleWithOperator::evaluate(Transaction *trans,
RuleMessage &ruleMessage) { RuleMessage &ruleMessage) {
bool globalRet = false; bool globalRet = false;
const variables::Variables *variables = this->m_variables; // cppcheck-suppress unreadVariable ; false positive
bool recursiveGlobalRet; bool recursiveGlobalRet;
bool containsBlock = hasBlockAction(); bool containsBlock = hasBlockAction();
std::string eparam; std::string eparam;
@ -246,12 +245,12 @@ bool RuleWithOperator::evaluate(Transaction *trans,
+ "\" with param " \ + "\" with param " \
+ eparam \ + eparam \
+ " against " \ + " against " \
+ variables + "."); + m_variables + ".");
} else { } else {
ms_dbg_a(trans, 4, "(Rule: " + std::to_string(m_ruleId) \ ms_dbg_a(trans, 4, "(Rule: " + std::to_string(m_ruleId) \
+ ") Executing operator \"" + getOperatorName() \ + ") Executing operator \"" + getOperatorName() \
+ " against " \ + " against " \
+ variables + "."); + m_variables + ".");
} }