github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-14 05:45:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Removed unnecessary break after return

Browse Source
This commit is contained in:
Eduardo Arias 2024-04-28 12:50:58 -03:00
parent 0cd2f459f3
commit cd2dded659
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/operators/validate_utf8_encoding.cc
View File

@ -132,7 +132,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
std::to_string(i) + "\"]"); std::to_string(i) + "\"]");
} }
return true; return true;
break;
case UNICODE_ERROR_INVALID_ENCODING : case UNICODE_ERROR_INVALID_ENCODING :
if (transaction) { if (transaction) {
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: " ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@ -142,7 +141,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
logOffset(ruleMessage, i, str.size()); logOffset(ruleMessage, i, str.size());
} }
return true; return true;
break;
case UNICODE_ERROR_OVERLONG_CHARACTER : case UNICODE_ERROR_OVERLONG_CHARACTER :
if (transaction) { if (transaction) {
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: " ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@ -152,7 +150,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
logOffset(ruleMessage, i, str.size()); logOffset(ruleMessage, i, str.size());
} }
return true; return true;
break;
case UNICODE_ERROR_RESTRICTED_CHARACTER : case UNICODE_ERROR_RESTRICTED_CHARACTER :
if (transaction) { if (transaction) {
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: " ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@ -162,7 +159,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
logOffset(ruleMessage, i, str.size()); logOffset(ruleMessage, i, str.size());
} }
return true; return true;
break;
case UNICODE_ERROR_DECODING_ERROR : case UNICODE_ERROR_DECODING_ERROR :
if (transaction) { if (transaction) {
ms_dbg_a(transaction, 8, "Error validating UTF-8 decoding " ms_dbg_a(transaction, 8, "Error validating UTF-8 decoding "
@ -171,7 +167,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
logOffset(ruleMessage, i, str.size()); logOffset(ruleMessage, i, str.size());
} }
return true; return true;
break;
} }
if (rc <= 0) { if (rc <= 0) {

1
test/cppcheck_suppressions.txt
View File

@ -44,7 +44,6 @@ functionStatic:src/engine/lua.h:71
functionConst:src/utils/geo_lookup.h:49 functionConst:src/utils/geo_lookup.h:49
useInitializationList:src/operators/rbl.h:69 useInitializationList:src/operators/rbl.h:69
functionStatic:src/operators/geo_lookup.h:35 functionStatic:src/operators/geo_lookup.h:35
duplicateBreak:src/operators/validate_utf8_encoding.cc
syntaxError:src/transaction.cc:62 syntaxError:src/transaction.cc:62
noConstructor:src/variables/variable.h:152 noConstructor:src/variables/variable.h:152
knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77 knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77