github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-09-29 11:16:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix argument uri decode order

Browse Source 
The uri decode happens after the string is splitted, not before.
This commit is contained in:
Felipe Zimmerle
2016-06-17 15:34:06 -03:00
parent dbaf79fb8e
commit c5262d54f2
2 changed files with 49 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
test/test-cases/regression/variable-ARGS_GET.json
View File

@@ -2,7 +2,7 @@
{
"enabled":1,
"version_min":300000,
"title":"Testing Variables :: ARGS_GET (1/2)",
"title":"Testing Variables :: ARGS_GET (1/3)",
"client":{
"ip":"200.249.12.31",
"port":123
@@ -40,10 +40,10 @@
"SecRule ARGS_GET \"@contains test \" \"id:1,pass,t:trim\""
]
},
{
{
"enabled":1,
"version_min":300000,
"title":"Testing Variables :: ARGS_GET (2/2)",
"title":"Testing Variables :: ARGS_GET (2/3)",
"client":{
"ip":"200.249.12.31",
"port":123
@@ -80,6 +80,47 @@
"SecDebugLogLevel 9",
"SecRule ARGS_GET \"@contains test \" \"id:1,pass,t:trim\""
]
},
{
"enabled":1,
"version_min":300000,
"title":"Testing Variables :: ARGS_GET (3/3)",
"client":{
"ip":"200.249.12.31",
"port":123
},
"server":{
"ip":"200.249.12.31",
"port":80
},
"request":{
"headers":{
"Host":"localhost",
"User-Agent":"curl/7.38.0",
"Accept":"*/*"
},
"uri":"/?key=value&key=other_value%26withsomestuff=tootherstuff",
"method":"GET"
},
"response":{
"headers":{
"Date":"Mon, 13 Jul 2015 20:02:41 GMT",
"Last-Modified":"Sun, 26 Oct 2014 22:33:37 GMT",
"Content-Type":"text/html"
},
"body":[
"no need."
]
},
"expected":{
"debug_log":"Target value: \"other_value&withsomestuff=tootherstuff\""
},
"rules":[
"SecRuleEngine On",
"SecDebugLog \/tmp\/modsec_debug.log",
"SecDebugLogLevel 9",
"SecRule ARGS_GET \"@contains test \" \"id:1,pass,t:trim\""
]
}
]