github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-11-16 09:31:53 +03:00
Code Issues Packages Projects Releases Wiki Activity

Minor codebase improvements suggested by Sonarcloud

Browse Source 
- src/modsecurity.cc
  - Replace the redundant type with "auto".
- src/transaction.cc
  - Avoid this unnecessary copy by using a "const" reference.
- test/common/custom_debug_log.cc
  - Use "=default" instead of the default implementation of this special
    member functions.
    - Removed the unnecessary destructor override instead.
  - Annotate this function with "override" or "final".
    - Removed the unnecessary destructor override instead.
  - Remove this "const" qualifier from the return type in all
    declarations.
- test/common/modsecurity_test_context.h
  - Replace the redundant type with "auto".
- test/regression/regression.cc
  - Use the "nullptr" literal.
  - Replace this declaration by a structured binding declaration.
  - Replace "reinterpret_cast" with a safer operation.
This commit is contained in:
Eduardo Arias
2024-09-10 14:47:00 -03:00
parent 4df297b596
commit b7b2d9a40d
6 changed files with 22 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/common/custom_debug_log.cc
View File

@@ -23,8 +23,6 @@
namespace modsecurity_test {
CustomDebugLog::~CustomDebugLog() {}
void CustomDebugLog::write(int level, const std::string &message) {
m_log << "[" << level << "] " << message << std::endl;
}
@@ -36,13 +34,13 @@ namespace modsecurity_test {
m_log << msgf << std::endl;
}
bool const CustomDebugLog::contains(const std::string &pattern) const {
bool CustomDebugLog::contains(const std::string &pattern) const {
modsecurity::Utils::Regex re(pattern);
std::string s = m_log.str();
return modsecurity::Utils::regex_search(s, re);
}
std::string const CustomDebugLog::log_messages() const {
std::string CustomDebugLog::log_messages() const {
return m_log.str();
}