github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-15 23:55:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

src/operators/verify_cc.cc: reduce the scope of variable in a for () loop

Browse Source 
In general, it is always preferable to reduce
the scope of a variable in a for loop
This commit is contained in:
Elia Pinto 2024-02-21 13:50:51 +01:00
parent 9842b92bd1
commit b23abf440a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/operators/verify_cc.cc
View File

@ -59,7 +59,6 @@ int VerifyCC::luhnVerify(const char *ccnumber, int len) {
int sum[2] = { 0, 0 }; int sum[2] = { 0, 0 };
int odd = 0; int odd = 0;
int digits = 0; int digits = 0;
int i;
/* Weighted lookup table which is just a precalculated (i = index): /* Weighted lookup table which is just a precalculated (i = index):
* i*2 + (( (i*2) > 9 ) ? -9 : 0) * i*2 + (( (i*2) > 9 ) ? -9 : 0)
@ -71,7 +70,7 @@ int VerifyCC::luhnVerify(const char *ccnumber, int len) {
/* Add up only digits (weighted digits via lookup table) /* Add up only digits (weighted digits via lookup table)
* for both odd and even CC numbers to avoid 2 passes. * for both odd and even CC numbers to avoid 2 passes.
*/ */
for (i = 0; i < len; i++) { for (int i = 0;i < len;i++) {
if (ccnumber[i] >= (0 + 48) && ccnumber[i] <= (9 + 48)) { if (ccnumber[i] >= (0 + 48) && ccnumber[i] <= (9 + 48)) {
sum[0] += (!odd ? wtable[ccnumber[i] - '0'] : (ccnumber[i] - '0')); sum[0] += (!odd ? wtable[ccnumber[i] - '0'] : (ccnumber[i] - '0'));
sum[1] += (odd ? wtable[ccnumber[i] - '0'] : (ccnumber[i] - '0')); sum[1] += (odd ? wtable[ccnumber[i] - '0'] : (ccnumber[i] - '0'));