github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-12-31 21:59:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak of RuleMessages objects

Browse Source
This commit is contained in:
martinhsv
2020-11-08 10:31:38 -08:00
committed by Felipe Zimmerle
parent 29364052cd
commit ab6754712c
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/transaction.cc
View File

@@ -64,11 +64,11 @@ namespace modsecurity {
RuleMessage *TransactionRuleMessageManagement::messageGetLast() {
return m_rulesMessages.back();
return m_rulesMessages.back().get();
}
void TransactionRuleMessageManagement::logMatchLastRuleOnTheChain(const RuleWithActions *rule) {
RuleMessage *rm = m_rulesMessages.back();
RuleMessage *rm = m_rulesMessages.back().get();
rm->setRule(rule);
@@ -85,13 +85,13 @@ void TransactionRuleMessageManagement::logMatchLastRuleOnTheChain(const RuleWith
}
void TransactionRuleMessageManagement::messageNew() {
m_rulesMessages.push_back(new RuleMessage(m_transaction));
m_rulesMessages.push_back(std::make_shared<RuleMessage>(m_transaction));
}
std::list<RuleMessage *> TransactionRuleMessageManagement::messageGetAll() {
std::list<RuleMessage *> messages;
for (RuleMessage *a : m_rulesMessages) {
messages.push_back(a);
for (auto iter = m_rulesMessages.begin(); iter != m_rulesMessages.end(); ++iter) {
messages.push_back((*iter).get());
}
return messages;
}