Fixing code based on review comments...

Cleaned up what vars are cacheable.
Added parens around "*foo++" where it clarified the operation to be "*(foo++)".
Added " at VARNAME" to operator matches where needed.
Escaped var->name in the var generation (user-supplied data).
Marked a bunch of TODOs as ENHs instead.
Transformed some C++ style comments to C style.
Removed the %0-9 macros code which was commented out.
Optimized some ctl action code so that multiple ifs are else ifs.
Implemented some error messages marked as ENH.
Make commented out acmp debugging a configure-time option.
Cleanup GEO debug log messages.
Added relative filename support for geo dbs.
Added help text to Sec* directives.

apache2/configure.in

@@ -150,6 +150,21 @@ AC_ARG_ENABLE(debug-cache,
   debug_cache=
 ])
 
+# DEBUG_ACMP
+AC_ARG_ENABLE(debug-acmp,
+              AS_HELP_STRING([--enable-debug-acmp],
+                             [Enable debugging acmp code.]),
+[
+  if test "$enableval" != "no"; then
+    debug_acmp="-DDEBUG_ACMP"
+  else
+    debug_acmp=
+  fi
+],
+[
+  debug_acmp=
+])
+
 # PERFORMANCE_MEASUREMENT
 AC_ARG_ENABLE(performance-measurement,
               AS_HELP_STRING([--enable-performance-measurement],
@@ -183,7 +198,7 @@ AC_ARG_ENABLE(modsec-api,
 ### Build *EXTRA_CFLAGS vars
 
 EXTRA_CFLAGS="-O2 -g -Wall -Werror"
-MODSEC_EXTRA_CFLAGS="$debug_conf $debug_cache $perf_meas $modsec_api"
+MODSEC_EXTRA_CFLAGS="$debug_conf $debug_cache $debug_acmp $perf_meas $modsec_api"
 
 APXS_EXTRA_CFLAGS=""
 for f in $EXTRA_CFLAGS; do