Cosmetics: fix some cppcheck complains to please QA

This commit is contained in:
Felipe Zimmerle
2020-04-29 10:19:49 -03:00
parent 310cbf899b
commit 9b40a045bb
26 changed files with 244 additions and 77 deletions

View File

@@ -39,8 +39,8 @@ functionStatic:headers/modsecurity/transaction.h:405
duplicateBranch:src/audit_log/audit_log.cc:223
unreadVariable:src/request_body_processor/multipart.cc:435
stlcstrParam:src/audit_log/writer/parallel.cc:145
functionStatic:src/engine/lua.h:70
functionStatic:src/engine/lua.h:71
functionStatic:src/engine/lua.h:72
functionConst:src/utils/geo_lookup.h:49
useInitializationList:src/operators/rbl.h:69
constStatement:test/common/modsecurity_test.cc:82
@@ -51,11 +51,12 @@ duplicateBranch:src/request_body_processor/multipart.cc:91
syntaxError:src/transaction.cc:62
noConstructor:src/variables/variable.h:152
duplicateBranch:src/request_body_processor/multipart.cc:93
knownConditionTrueFalse:src/utils/geo_lookup.cc:94
knownConditionTrueFalse:src/utils/geo_lookup.cc:98
danglingTempReference:src/modsecurity.cc:204
knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77
knownConditionTrueFalse:src/operators/verify_svnr.cc:87
noExplicitConstructor:seclang-parser.hh
constParameter:seclang-parser.hh
unusedFunction
missingIncludeSystem
@@ -65,3 +66,9 @@ funcArgNamesDifferent
unmatchedSuppression
missingInclude
purgedConfiguration
// Examples
memleak:examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h:147
memleak:examples/using_bodies_in_chunks/simple_request.cc

View File

@@ -128,7 +128,9 @@ inline void op_test(const std::string &opName, const std::string &s) {
int main(int argc, char** argv) {
uint8_t buf[128];
#if 0
std::string lastString;
#endif
while (__AFL_LOOP(1000)) {
ssize_t read_bytes;
@@ -138,7 +140,9 @@ int main(int argc, char** argv) {
std::string currentString = std::string(read_bytes, 128);
std::string s = currentString;
#if 0
std::string z = lastString;
#endif
ModSecurity *ms = new ModSecurity();
RulesSet *rules = new RulesSet();
@@ -266,8 +270,9 @@ op_test("Within", s);
delete t;
delete rules;
delete ms;
#if 0
lastString = currentString;
#endif
}
return 0;
}