github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-13 13:26:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

SonarCloud fixes: replace is_signed<T>::value to is_signed_v<T>; add specific catch() blocks

Browse Source
This commit is contained in:
Ervin Hegedus 2025-07-23 21:15:43 +02:00
parent f56db1b80c
commit 8ea580c164
No known key found for this signature in database
GPG Key ID: 5FA5BC3F5EC41F61
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
headers/modsecurity/rules_set_properties.h
View File

@ -96,19 +96,29 @@ public:
bool parse(const std::string& a, std::string* errmsg = nullptr) {
// use an alias type because the template can convert both signed and unsigned int
using LimitSigned = std::conditional_t<std::is_signed<T>::value, long long, unsigned long long>;
using LimitSigned = std::conditional_t<std::is_signed_v<T>, long long, unsigned long long>;
LimitSigned val;
// clear errno variable, wee need that later
errno = 0;
try {
if constexpr (std::is_signed<T>::value) {
if constexpr (std::is_signed_v<T>) {
val = std::stoll(a);
} else {
val = std::stoull(a);
}
} catch (...) {
}
catch (const std::invalid_argument&) {
// probably can't occur, but we handle it anyway
if (errmsg) *errmsg = "Invalid number format (not numeric)";
return false;
}
catch (const std::out_of_range&) {
if (errmsg) *errmsg = "Number out of range";
return false;
}
catch (...) {
// we don't need to handle all exceptions, the engine's BISON parser
// does not allow other symbols than numbers
if (errmsg) *errmsg = "An unknown error occurred while parsed the value.";