github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-17 22:56:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add ostensibly unnecessary null check

Browse Source
This commit is contained in:
Martin Vierula 2023-01-04 06:56:54 -08:00
parent 8038a529c0
commit 8b3b7a0e23
No known key found for this signature in database
GPG Key ID: F2FC4E45883BCBA4
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
apache2/re_variables.c
View File

@ -1431,18 +1431,20 @@ static int var_multipart_part_headers_generate(modsec_rec *msr, msre_var *var, m
/* If we had a match add this argument to the collection. */ /* If we had a match add this argument to the collection. */
if (match) { if (match) {
for (j = 0; j < parts[i]->header_lines->nelts; j++) { if (parts[i]->header_lines) { /* this NULL check shouldn't be necessary */
char *header_line = ((char **)parts[i]->header_lines->elts)[j]; for (j = 0; j < parts[i]->header_lines->nelts; j++) {
msre_var *rvar = apr_pmemdup(mptmp, var, sizeof(msre_var)); char *header_line = ((char **)parts[i]->header_lines->elts)[j];
msre_var *rvar = apr_pmemdup(mptmp, var, sizeof(msre_var));
rvar->value = header_line; rvar->value = header_line;
rvar->value_len = strlen(rvar->value); rvar->value_len = strlen(rvar->value);
rvar->name = apr_psprintf(mptmp, "MULTIPART_PART_HEADERS:%s", rvar->name = apr_psprintf(mptmp, "MULTIPART_PART_HEADERS:%s",
log_escape_nq(mptmp, parts[i]->name)); log_escape_nq(mptmp, parts[i]->name));
apr_table_addn(vartab, rvar->name, (void *)rvar); apr_table_addn(vartab, rvar->name, (void *)rvar);
count++; count++;
} }
}
} }
} }