github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-09-30 03:34:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Cosmetics: Reduces the static analysis warnings

Browse Source
This commit is contained in:
Felipe Zimmerle
2016-12-28 17:46:47 -03:00
parent 9c7416da97
commit 88fb456a16
12 changed files with 37 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/request_body_processor/multipart.cc
View File

@@ -36,33 +36,35 @@ namespace RequestBodyProcessor {
Multipart::Multipart(std:: string header, Transaction *transaction)
: m_boundary_count(0),
: m_reqbody_no_files_length(0),
m_nfiles(0),
m_boundary_count(0),
m_buf{0},
m_buf_contains_line(0),
m_bufptr(NULL),
m_bufleft(0),
m_buf_offset(0),
m_bufptr(NULL),
m_flag_boundary_quoted(0),
m_flag_boundary_whitespace(0),
m_flag_crlf_line(0),
m_flag_data_after(0),
m_flag_data_before(0),
m_flag_error(0),
m_flag_file_limit_exceeded(0),
m_flag_header_folding(0),
m_flag_invalid_header_folding(0),
m_flag_invalid_part(0),
m_flag_invalid_quoting(0),
m_flag_lf_line(0),
m_flag_missing_semicolon(0),
m_flag_unmatched_boundary(0),
m_header(header),
m_is_complete(0),
m_mpp(NULL),
m_mpp_state(0),
m_nfiles(0),
m_reserve{0},
m_seen_data(0),
m_transaction(transaction),
m_reqbody_no_files_length(0)
{ }
m_is_complete(0),
m_flag_error(0),
m_flag_data_before(0),
m_flag_data_after(0),
m_flag_header_folding(0),
m_flag_boundary_quoted(0),
m_flag_lf_line(0),
m_flag_crlf_line(0),
m_flag_unmatched_boundary(0),
m_flag_boundary_whitespace(0),
m_flag_missing_semicolon(0),
m_flag_invalid_quoting(0),
m_flag_invalid_part(0),
m_flag_invalid_header_folding(0),
m_flag_file_limit_exceeded(0),
m_header(header),
m_transaction(transaction) { }
Multipart::~Multipart() {
@@ -398,7 +400,7 @@ int Multipart::parse_content_disposition(const char *c_d_value) {
}
int Multipart::tmp_file_name(std::string *filename) {
int Multipart::tmp_file_name(std::string *filename) const {
std::string path;
struct tm timeinfo;
char tstr[300];
@@ -1197,7 +1199,7 @@ bool Multipart::init(std::string *error) {
}
/* Case-insensitive test for the string "boundary" in the boundary. */
if (count_boundary_params(m_boundary.c_str()) != 0) {
if (count_boundary_params(m_boundary) != 0) {
m_flag_error = 1;
debug(4, "Multipart: Invalid boundary in C-T (content).");
error->assign("Multipart: Invalid boundary in C-T (content).");

2
src/request_body_processor/multipart.h
View File

@@ -113,7 +113,7 @@ class Multipart {
int process_part_header(std::string *error);
int process_part_data(std::string *error);
int tmp_file_name(std::string *filename);
int tmp_file_name(std::string *filename) const;
void validate_quotes(const char *data);