From 8898759c472c4c1531c3aa9e28a16802b962497e Mon Sep 17 00:00:00 2001 From: brectanus Date: Wed, 7 Mar 2007 16:54:41 +0000 Subject: [PATCH] Add back the check for overflow on length --- apache2/msc_parsers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apache2/msc_parsers.c b/apache2/msc_parsers.c index 2922bf0b..b3720554 100644 --- a/apache2/msc_parsers.c +++ b/apache2/msc_parsers.c @@ -211,7 +211,9 @@ int parse_arguments(modsec_rec *msr, const char *s, apr_size_t inputlength, if (s == NULL) return -1; if (inputlength == 0) return 1; - if (inputlength < 0) return -1; + + /* Check that adding one will not overflow */ + if (inputlength + 1 <= 0) return -1; buf = (char *)malloc(inputlength + 1); if (buf == NULL) return -1;