Cosmetics: fixed static analysis issues.

This commit is contained in:
Felipe Zimmerle
2020-01-15 20:35:59 -03:00
parent 1fc5847919
commit 86a5f471a9
21 changed files with 54 additions and 40 deletions

View File

@@ -76,12 +76,12 @@ void Variable::addsKeyExclusion(Variable *v) {
}
std::string operator+(std::string a, Variable *v) {
std::string operator+(const std::string &a, Variable *v) {
return a + *v->m_fullName.get();
}
std::string operator+(std::string a, Variables *v) {
std::string operator+(const std::string &a, Variables *v) {
std::string test;
for (auto &b : *v) {
if (test.empty()) {

View File

@@ -669,8 +669,8 @@ class VariableModificatorCount : public Variable {
};
std::string operator+(std::string a, modsecurity::variables::Variable *v);
std::string operator+(std::string a, modsecurity::variables::Variables *v);
std::string operator+(const std::string &a, modsecurity::variables::Variable *v);
std::string operator+(const std::string &a, modsecurity::variables::Variables *v);
} // namespace variables

View File

@@ -61,7 +61,7 @@ void XML::evaluate(Transaction *t,
std::string param;
const xmlChar* xpathExpr = NULL;
int i;
size_t pos;
//size_t pos;
param = m_name;
/*