From 40c6f80ccffb16cf16c6e7ec525aea5fa8f5e828 Mon Sep 17 00:00:00 2001 From: Marc Stern Date: Tue, 3 Oct 2023 16:50:12 +0200 Subject: [PATCH] Avoid some useless code and memory allocation in case no macro is present --- apache2/re_actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/apache2/re_actions.c b/apache2/re_actions.c index 02ec07d2..94909c55 100644 --- a/apache2/re_actions.c +++ b/apache2/re_actions.c @@ -273,6 +273,7 @@ int expand_macros(modsec_rec *msr, msc_string *var, msre_rule *rule, apr_pool_t next_text_start = p + 1; } } else { + if (arr->nelts == 0) return 0; /* no macro */ /* Text part. */ part = (msc_string *)apr_pcalloc(mptmp, sizeof(msc_string)); part->value = apr_pstrdup(mptmp, text_start);