From 7d9c80dedee332a469fb8f16be421ce1dfe31253 Mon Sep 17 00:00:00 2001
From: Eduardo Arias <eduar_hte@hotmail.com>
Date: Sun, 28 Apr 2024 23:40:50 -0300
Subject: [PATCH] Address cppcheck warnings: uselessOverride (The function
 '...' overrides a function in a base class but is identical to the overridden
 function)

---
 src/actions/expire_var.cc | 5 -----
 src/actions/expire_var.h  | 1 -
 src/actions/set_env.cc    | 5 -----
 src/actions/set_env.h     | 1 -
 src/actions/set_rsc.cc    | 5 -----
 src/actions/set_rsc.h     | 1 -
 src/actions/set_sid.cc    | 5 -----
 src/actions/set_sid.h     | 1 -
 src/actions/set_uid.cc    | 5 -----
 src/actions/set_uid.h     | 1 -
 src/actions/set_var.cc    | 5 -----
 src/actions/set_var.h     | 1 -
 12 files changed, 36 deletions(-)

diff --git a/src/actions/expire_var.cc b/src/actions/expire_var.cc
index 988bc6c6..ffc89f47 100644
--- a/src/actions/expire_var.cc
+++ b/src/actions/expire_var.cc
@@ -32,11 +32,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool ExpireVar::init(std::string *error) {
-    return true;
-}
-
-
 bool ExpireVar::evaluate(RuleWithActions *rule, Transaction *t) {
 
     std::string expireExpressionExpanded(m_string->evaluate(t));
diff --git a/src/actions/expire_var.h b/src/actions/expire_var.h
index f0ca7496..3c15e986 100644
--- a/src/actions/expire_var.h
+++ b/src/actions/expire_var.h
@@ -40,7 +40,6 @@ class ExpireVar : public Action {
             m_string(std::move(z)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
 
diff --git a/src/actions/set_env.cc b/src/actions/set_env.cc
index 29290653..a14c0ad3 100644
--- a/src/actions/set_env.cc
+++ b/src/actions/set_env.cc
@@ -26,11 +26,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool SetENV::init(std::string *error) {
-    return true;
-}
-
-
 bool SetENV::evaluate(RuleWithActions *rule, Transaction *t) {
     std::string colNameExpanded(m_string->evaluate(t));
 
diff --git a/src/actions/set_env.h b/src/actions/set_env.h
index cc24c285..abdc6b5d 100644
--- a/src/actions/set_env.h
+++ b/src/actions/set_env.h
@@ -40,7 +40,6 @@ class SetENV : public Action {
             m_string(std::move(z)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
     std::unique_ptr<RunTimeString> m_string;
diff --git a/src/actions/set_rsc.cc b/src/actions/set_rsc.cc
index 8464a9b6..5b31c0a1 100644
--- a/src/actions/set_rsc.cc
+++ b/src/actions/set_rsc.cc
@@ -26,11 +26,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool SetRSC::init(std::string *error) {
-    return true;
-}
-
-
 bool SetRSC::evaluate(RuleWithActions *rule, Transaction *t) {
     std::string colNameExpanded(m_string->evaluate(t));
     ms_dbg_a(t, 8, "RESOURCE initiated with value: \'"
diff --git a/src/actions/set_rsc.h b/src/actions/set_rsc.h
index 7830ee92..2264e82b 100644
--- a/src/actions/set_rsc.h
+++ b/src/actions/set_rsc.h
@@ -40,7 +40,6 @@ class SetRSC : public Action {
             m_string(std::move(z)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
     std::unique_ptr<RunTimeString> m_string;
diff --git a/src/actions/set_sid.cc b/src/actions/set_sid.cc
index c7a0db68..4117d351 100644
--- a/src/actions/set_sid.cc
+++ b/src/actions/set_sid.cc
@@ -26,11 +26,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool SetSID::init(std::string *error) {
-    return true;
-}
-
-
 bool SetSID::evaluate(RuleWithActions *rule, Transaction *t) {
     std::string colNameExpanded(m_string->evaluate(t));
     ms_dbg_a(t, 8, "Session ID initiated with value: \'"
diff --git a/src/actions/set_sid.h b/src/actions/set_sid.h
index dca45433..1048caef 100644
--- a/src/actions/set_sid.h
+++ b/src/actions/set_sid.h
@@ -40,7 +40,6 @@ class SetSID : public Action {
             m_string(std::move(z)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
     std::unique_ptr<RunTimeString> m_string;
diff --git a/src/actions/set_uid.cc b/src/actions/set_uid.cc
index 997df77b..01f74b84 100644
--- a/src/actions/set_uid.cc
+++ b/src/actions/set_uid.cc
@@ -26,11 +26,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool SetUID::init(std::string *error) {
-    return true;
-}
-
-
 bool SetUID::evaluate(RuleWithActions *rule, Transaction *t) {
     std::string colNameExpanded(m_string->evaluate(t));
     ms_dbg_a(t, 8, "User collection initiated with value: \'"
diff --git a/src/actions/set_uid.h b/src/actions/set_uid.h
index 76893999..49a36c1d 100644
--- a/src/actions/set_uid.h
+++ b/src/actions/set_uid.h
@@ -40,7 +40,6 @@ class SetUID : public Action {
             m_string(std::move(z)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
     std::unique_ptr<RunTimeString> m_string;
diff --git a/src/actions/set_var.cc b/src/actions/set_var.cc
index f30ae188..70c07d06 100644
--- a/src/actions/set_var.cc
+++ b/src/actions/set_var.cc
@@ -35,11 +35,6 @@ namespace modsecurity {
 namespace actions {
 
 
-bool SetVar::init(std::string *error) {
-    return true;
-}
-
-
 bool SetVar::evaluate(RuleWithActions *rule, Transaction *t) {
     std::string targetValue;
     std::string resolvedPre;
diff --git a/src/actions/set_var.h b/src/actions/set_var.h
index 5fe9de03..e89e8be7 100644
--- a/src/actions/set_var.h
+++ b/src/actions/set_var.h
@@ -59,7 +59,6 @@ class SetVar : public Action {
         m_variable(std::move(variable)) { }
 
     bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
-    bool init(std::string *error) override;
 
  private:
     SetVarOperation m_operation;